feat(rebuild): adding rebuild I/O verification #1459

dsavitskiy · 2023-07-19T12:32:51Z

No description provided.

dsavitskiy · 2023-07-19T12:33:06Z

bors try

bors · 2023-07-19T12:35:05Z

try

Build failed:

continuous-integration/jenkins/branch

dsavitskiy · 2023-07-19T12:46:08Z

bors try

bors · 2023-07-19T13:10:50Z

try

Build failed:

continuous-integration/jenkins/branch

dsavitskiy · 2023-07-20T11:53:06Z

bors try

bors · 2023-07-20T13:11:15Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

Jenkinsfile

io-engine/src/core/block_device.rs

io-engine/src/rebuild/rebuild_task.rs

dsavitskiy · 2023-07-28T20:51:21Z

bors try

bors · 2023-07-28T21:16:03Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

dsavitskiy · 2023-07-30T10:03:44Z

bors try

bors · 2023-07-30T10:28:01Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

dsavitskiy · 2023-07-30T20:43:22Z

bors try

bors · 2023-07-30T21:08:53Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

io-engine/src/rebuild/rebuild_task.rs

io-engine/src/rebuild/rebuild_descriptor.rs

bors · 2023-08-01T08:35:07Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

io-engine/src/rebuild/rebuild_descriptor.rs

io-engine/src/bdev/nexus/nexus_bdev_rebuild.rs

io-engine/src/rebuild/rebuild_descriptor.rs

io-engine-tests/src/test.rs

io-engine/src/rebuild/rebuild_descriptor.rs

dsavitskiy · 2023-08-15T13:34:32Z

bors merge

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

bors · 2023-08-15T14:01:47Z

Build failed:

continuous-integration/jenkins/branch

Changes to `BlockDeviceHandle` trait: * `readv_blocks` and `writev_blocks` now accept `IoVec` slice instead of C-array of iovs and its length. * `ReadOptions` argument is now passed to `readv_blocks` instead of `read_at`. * New async methods added: - `readv_blocks_async` - `read_buf_blocks_async` - `writev_blocks_async` - `write_buf_blocks_async` These methods have default implementions in `BlockDeviceHandle`, based on `readv_blocks` and `writev_blocks` calls. * `read_at` and `write_at` are now deprecated. Rebuild task is changed to use `BlockDeviceHandle` methods. Signed-off-by: Dmitry Savitskiy <[email protected]>

Fault injections moved from nexus to core. Support for block-device level injection added. New 'testing' gRPC service added. Injections removed from v0 API. CLI is changed accordingly. Signed-off-by: Dmitry Savitskiy <[email protected]>

At this moment rebuild verification is controlled via NEXUS_REBUILD_VERIFY shell var: - "fail": rebuild job fails if verification fails - "panic": I/O engine panics if verification fails - any other value or not set: do no verify Signed-off-by: Dmitry Savitskiy <[email protected]>

Signed-off-by: Dmitry Savitskiy <[email protected]>

dsavitskiy · 2023-08-15T14:08:46Z

bors merge

bors · 2023-08-15T14:08:50Z

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

bors · 2023-08-15T14:53:17Z

This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

dsavitskiy · 2023-08-15T17:54:41Z

bors merge

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

dsavitskiy · 2023-08-15T19:10:30Z

bors merge

bors · 2023-08-15T19:34:27Z

Already running a review

bors · 2023-08-15T20:16:39Z

This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

dsavitskiy · 2023-08-16T08:22:04Z

bors merge

bors · 2023-08-16T08:49:22Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/jenkins/branch

auto-assign bot requested review from blaisedias and tiagolobocastro July 19, 2023 12:32

bors bot pushed a commit that referenced this pull request Jul 19, 2023

Try #1459:

5e0f36a

bors bot pushed a commit that referenced this pull request Jul 19, 2023

Try #1459:

f8b54a0

bors bot pushed a commit that referenced this pull request Jul 20, 2023

Try #1459:

02327b1

dsavitskiy force-pushed the feature/rebuild-verify branch from ecbcdbe to 040a557 Compare July 20, 2023 12:28

tiagolobocastro reviewed Jul 20, 2023

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

io-engine/src/core/block_device.rs Outdated Show resolved Hide resolved

io-engine/src/rebuild/rebuild_task.rs Outdated Show resolved Hide resolved

dsavitskiy force-pushed the feature/rebuild-verify branch from 040a557 to f6a730d Compare July 28, 2023 20:42

bors bot pushed a commit that referenced this pull request Jul 28, 2023

Try #1459:

63bbf33

dsavitskiy force-pushed the feature/rebuild-verify branch from f6a730d to 3298bda Compare July 30, 2023 10:02

bors bot pushed a commit that referenced this pull request Jul 30, 2023

Try #1459:

136663a

dsavitskiy force-pushed the feature/rebuild-verify branch from 3298bda to 2c9eec1 Compare July 30, 2023 20:42

bors bot pushed a commit that referenced this pull request Jul 30, 2023

Try #1459:

b1048aa

dsavitskiy requested review from tiagolobocastro, mtzaurus and dsharma-dc July 30, 2023 20:44

tiagolobocastro reviewed Jul 31, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_task.rs Outdated Show resolved Hide resolved

tiagolobocastro reviewed Jul 31, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

dsavitskiy force-pushed the feature/rebuild-verify branch from da78532 to 8ac46c2 Compare August 1, 2023 09:35

tiagolobocastro approved these changes Aug 1, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

io-engine/src/bdev/nexus/nexus_bdev_rebuild.rs Show resolved Hide resolved

dsharma-dc reviewed Aug 14, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

io-engine-tests/src/test.rs Outdated Show resolved Hide resolved

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

dsavitskiy force-pushed the feature/rebuild-verify branch from 8ac46c2 to 7d81238 Compare August 14, 2023 09:55

dsavitskiy requested a review from dsharma-dc August 14, 2023 09:58

dsharma-dc approved these changes Aug 14, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

tiagolobocastro reviewed Aug 14, 2023

View reviewed changes

io-engine/src/rebuild/rebuild_descriptor.rs Show resolved Hide resolved

dsavitskiy force-pushed the feature/rebuild-verify branch from 7d81238 to 92ba6c4 Compare August 15, 2023 13:33

bors bot pushed a commit that referenced this pull request Aug 15, 2023

Merge #1459

68d6e17

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

dsavitskiy added 4 commits August 15, 2023 17:05

fix(ci): allowing bors try when submodule PR is not merged yet

d1783cd

Signed-off-by: Dmitry Savitskiy <[email protected]>

dsavitskiy force-pushed the feature/rebuild-verify branch from 92ba6c4 to d1783cd Compare August 15, 2023 14:08

bors bot pushed a commit that referenced this pull request Aug 15, 2023

Merge #1459

aabc05f

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

bors bot pushed a commit that referenced this pull request Aug 15, 2023

Merge #1459

d7f2fd5

1459: feat(rebuild): adding rebuild I/O verification r=dsavitskiy a=dsavitskiy Co-authored-by: Dmitry Savitskiy <[email protected]>

bors bot merged commit 47d0450 into openebs:develop Aug 16, 2023
3 checks passed

dsavitskiy deleted the feature/rebuild-verify branch August 16, 2023 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rebuild): adding rebuild I/O verification #1459

feat(rebuild): adding rebuild I/O verification #1459

dsavitskiy commented Jul 19, 2023

dsavitskiy commented Jul 19, 2023

bors bot commented Jul 19, 2023

dsavitskiy commented Jul 19, 2023

bors bot commented Jul 19, 2023

dsavitskiy commented Jul 20, 2023

bors bot commented Jul 20, 2023

dsavitskiy commented Jul 28, 2023

bors bot commented Jul 28, 2023

dsavitskiy commented Jul 30, 2023

bors bot commented Jul 30, 2023

dsavitskiy commented Jul 30, 2023

bors bot commented Jul 30, 2023

bors bot commented Aug 1, 2023

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 16, 2023

bors bot commented Aug 16, 2023

feat(rebuild): adding rebuild I/O verification #1459

feat(rebuild): adding rebuild I/O verification #1459

Conversation

dsavitskiy commented Jul 19, 2023

dsavitskiy commented Jul 19, 2023

bors bot commented Jul 19, 2023

try

dsavitskiy commented Jul 19, 2023

bors bot commented Jul 19, 2023

try

dsavitskiy commented Jul 20, 2023

bors bot commented Jul 20, 2023

try

dsavitskiy commented Jul 28, 2023

bors bot commented Jul 28, 2023

try

dsavitskiy commented Jul 30, 2023

bors bot commented Jul 30, 2023

try

dsavitskiy commented Jul 30, 2023

bors bot commented Jul 30, 2023

try

bors bot commented Aug 1, 2023

try

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

dsavitskiy commented Aug 15, 2023

bors bot commented Aug 15, 2023

bors bot commented Aug 15, 2023

dsavitskiy commented Aug 16, 2023

bors bot commented Aug 16, 2023