Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nexus): fixing child retire during rebuild #1436

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix(nexus): fixing child retire during rebuild #1436

merged 2 commits into from
Jul 19, 2023

Conversation

dsavitskiy
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from blaisedias June 28, 2023 07:14
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jun 28, 2023
Try #1436:
adbcc3d
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build failed:

@tiagolobocastro
Copy link
Contributor

CI was borked..
bors try

bors bot pushed a commit that referenced this pull request Jun 28, 2023
Try #1436:
7a671e0
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dsavitskiy dsavitskiy force-pushed the feature/rebuild-stuck branch 2 times, most recently from a29cb3b to 365919b Compare June 28, 2023 10:16
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jun 28, 2023
Try #1436:
c5cb425
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dsavitskiy
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 30, 2023
@dsavitskiy
Merge #1436
5626720 
1436: fix(nexus): fixing child retire during rebuild r=dsavitskiy a=dsavitskiy



Co-authored-by: Dmitry Savitskiy <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Timed out.

@dsavitskiy
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 3, 2023
@dsavitskiy
Merge #1436
338faca 
1436: fix(nexus): fixing child retire during rebuild r=dsavitskiy a=dsavitskiy



Co-authored-by: Dmitry Savitskiy <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Timed out.

@dsavitskiy
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot pushed a commit that referenced this pull request Jul 6, 2023
@dsavitskiy
Merge #1436
ce677f7 
1436: fix(nexus): fixing child retire during rebuild r=dsavitskiy a=dsavitskiy



Co-authored-by: Dmitry Savitskiy <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Timed out.

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jul 6, 2023
Try #1436:
a12ed0f
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@tiagolobocastro
Copy link
Contributor

Odd, seems like the python tests are taking 3h to complete!

@tiagolobocastro
Copy link
Contributor

Can you look into this before merging @dsavitskiy ? This would severely affect our CI given we have only 1 system to run the python tests atm..

@dsavitskiy
Copy link
Contributor Author

dsavitskiy commented Jul 7, 2023 •
edited
Loading

Yes sure, I won't be merging this. I was sure that I fixed the stuck python test but obviously it is not the case.
I won't bors try again before the release is done, as it affects CI.

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jul 18, 2023
Try #1436:
d3237ec
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build failed:

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jul 18, 2023
Try #1436:
ce026da
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build failed:

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jul 18, 2023
Try #1436:
87a2ca5
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Timed out.

@dsavitskiy
fix(nexus): fixing nexus unshare and nvmf error handling
fa9a41e 
NVMF subsystem API and Nexus unshare had some issues with error handling,
which could potentially lead to use-after-free.

Signed-off-by: Dmitry Savitskiy <[email protected]>
@dsavitskiy
fix(nexus): fixing child retire during rebuild
48c8dc1 
* Fixed stuck rebuild job when a child is retired during rebuild
* Fixed stuck nexus destroy if the nexus had a rebuild job failed
* A Python test for retire-during rebuild added

Signed-off-by: Dmitry Savitskiy <[email protected]>
@dsavitskiy
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 19, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 165623f into openebs:release/1.0 Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtzaurus mtzaurus mtzaurus approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

@blaisedias blaisedias Awaiting requested review from blaisedias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsavitskiy @tiagolobocastro @mtzaurus