feat(composer): allow setting 'host' network mode #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
requested review from
tiagolobocastro,
sinhaashish,
Abhinandan-Purkait and
abhilashshetty04
| @@ -694,6 +702,12 @@ impl Builder { | |||
| Ok(self) | |||
| } | |||
|
|
|||
| /// set the network mode for this test. | |||
| pub fn network_mode(mut self, mode: &str) -> Result<Builder, Error> { | |||
There was a problem hiding this comment.
What is mode? Suggest you use an enum for the public facing api
| if self.network_mode.is_none() { | ||
| compose.network_id = compose.network_create().await.map_err(|e| e.to_string())?; | ||
| } else { | ||
| let host_nw = &compose.host_network().await?[0]; |
There was a problem hiding this comment.
what is [0] index here?
| compose.network_id = compose.network_create().await.map_err(|e| e.to_string())?; | ||
| } else { | ||
| let host_nw = &compose.host_network().await?[0]; | ||
| compose.network_id = host_nw.id.clone().unwrap(); |
There was a problem hiding this comment.
Should return an error if no [0] and this unwrap
| @@ -1282,7 +1319,7 @@ impl ComposeTest { | |||
| async fn create_container( | |||
| &self, | |||
| spec: &ContainerSpec, | |||
| ipv4: Ipv4Addr, | |||
| ipv4: Option<Ipv4Addr>, | |||
There was a problem hiding this comment.
Why is the ip optional, because it's not in control of docker so it's up to the host?
Can we not set 127.0.0.1 in case of host?
| let mut env = self.spec_environment(spec); | ||
| env.push(format!("MY_POD_IP={ipv4}")); | ||
| let mut env = spec.environment(); | ||
| env.push(format!("MY_POD_IP={:?}", ipv4.unwrap_or(Ipv4Addr::new(127, 0, 0, 1)))); |
There was a problem hiding this comment.
Ah so every container gets the same ip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be refined further as use case evolves.