Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eventing): add nexus events in protobuf #37

Merged
merged 1 commit into from
Aug 25, 2023
Merged

feat(eventing): add nexus events in protobuf #37

merged 1 commit into from
Aug 25, 2023

Conversation

datacore-vvarakantham
Copy link
Contributor

@datacore-vvarakantham datacore-vvarakantham commented Aug 8, 2023 •
edited
Loading

Added nexus category and rebuild, stateChange actions in event protobuf

chriswldenyer
chriswldenyer reviewed Aug 14, 2023
View reviewed changes
Copy link

@chriswldenyer chriswldenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.
Ideally we would like event-specific data fo the rebuild, but that can be in a later PR.

@tiagolobocastro tiagolobocastro merged commit 0d3352f into openebs:develop Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@chriswldenyer chriswldenyer chriswldenyer approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datacore-vvarakantham @tiagolobocastro @sinhaashish @chriswldenyer