Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eventing): init with optional spawn function #36

Merged
merged 1 commit into from
Aug 9, 2023
Merged

feat(eventing): init with optional spawn function #36

merged 1 commit into from
Aug 9, 2023

Conversation

datacore-vvarakantham
Copy link
Contributor

With this code, we can use task spawning functionality in data plane

tiagolobocastro
tiagolobocastro approved these changes Aug 7, 2023
View reviewed changes
event-publisher/src/event_handler.rs Outdated Show resolved Hide resolved
event-publisher/src/event_handler.rs Outdated Show resolved Hide resolved
event-publisher/src/event_handler.rs Outdated Show resolved Hide resolved
tiagolobocastro
tiagolobocastro reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename PR and commit to simply feat(eventing): init with optional spawn function

@datacore-vvarakantham datacore-vvarakantham changed the title feat(eventing): add optional spawn function to run the publisher on tokio within mayastorC feat(eventing): init with optional spawn function Aug 7, 2023
sinhaashish
sinhaashish approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagolobocastro tiagolobocastro merged commit 5e5cbdf into openebs:develop Aug 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datacore-vvarakantham @tiagolobocastro @sinhaashish