feat(callhome): change the events tracing target from 'mbus-target' to 'mbus-events-target' #35
Conversation
Signed-off-by: Vandana Varakantham <[email protected]>
datacore-vvarakantham
requested review from
tiagolobocastro,
sinhaashish and
chriswldenyer
| @@ -35,7 +35,7 @@ impl EventMessage { | |||
| /// Generate the event trace with event message. | |||
| pub fn generate(&self) { | |||
| let event_data = serde_json::to_string(&self).unwrap_or_default(); | |||
| tracing::event!(target: "target-mbus", tracing::Level::INFO, event_data); | |||
| tracing::event!(target: "mbus-events-target", tracing::Level::INFO, event_data); | |||
There was a problem hiding this comment.
btw, should we only add event in case serde_json above is ok? Atm we're doing it for default which will be bogus if json to string fails..
There was a problem hiding this comment.
What should be done if there is an error? Should I print the error message to debug?
There was a problem hiding this comment.
Yeah perhaps? Though might be better to leave as is, and let event subscribers pick up, presumably they'd flag receiving empty String when they expect an event type?
There was a problem hiding this comment.
Yes. Stats module will probably trace the unknown events. Will have to check.
There was a problem hiding this comment.
The message will not be published to the mbus, as the message id is empty. The events-api lib gives the InvalidMessageId error.
No description provided.