Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(callhome): event publisher lib #34

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat(callhome): event publisher lib #34

merged 2 commits into from
Jul 17, 2023

Conversation

datacore-vvarakantham
Copy link
Contributor

Event publisher library.

tiagolobocastro
tiagolobocastro reviewed Jun 28, 2023
View reviewed changes
event-publisher/src/common/constants.rs Show resolved Hide resolved
event-publisher/src/publisher.rs Outdated Show resolved Hide resolved
event-publisher/src/publisher.rs Outdated Show resolved Hide resolved
event-publisher/src/event_layer.rs Outdated Show resolved Hide resolved
tiagolobocastro
tiagolobocastro reviewed Jul 12, 2023
View reviewed changes
event-publisher/src/event_layer.rs Outdated Show resolved Hide resolved
event-publisher/src/publisher.rs Outdated Show resolved Hide resolved
event-publisher/Cargo.toml Show resolved Hide resolved
sinhaashish
sinhaashish reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mbus api are used internally and eventing is a wrapper around this, Since we are using the eventing feature everywhere in our code base and mbus is used internally , we can rename it to events-api.

event-publisher/Cargo.toml Outdated Show resolved Hide resolved
event-publisher/src/common/constants.rs Outdated Show resolved Hide resolved
event-publisher/src/event_layer.rs Outdated Show resolved Hide resolved
event-publisher/src/lib.rs Show resolved Hide resolved
event-publisher/Cargo.toml Show resolved Hide resolved
@openebs openebs deleted a comment from datacore-vvarakantham Jul 13, 2023
feat(callhome): add publisher library
8098d58 
Signed-off-by: Vandana Varakantham <[email protected]>
@datacore-vvarakantham datacore-vvarakantham force-pushed the publisher-lib branch 3 times, most recently from ebda78c to f3be790 Compare July 17, 2023 07:37
@openebs openebs deleted a comment from bors bot Jul 17, 2023
feat(callhome): add publisher library
c46028e 
Signed-off-by: Vandana Varakantham <[email protected]>
@tiagolobocastro tiagolobocastro merged commit b29e863 into openebs:develop Jul 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

@niladrih niladrih Awaiting requested review from niladrih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datacore-vvarakantham @tiagolobocastro @sinhaashish