feat(provisioner-localpv): Merge CAS config from PersistentVolumeClaim #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
force-pushed
the
nobidev/features/merge-cas-pvc
branch
from
a7ada41
to
88bc07a
Compare
Abhinandan-Purkait
approved these changes
Jul 1, 2024
7 tasks
niladrih
requested review from
abhilashshetty04,
dsharma-dc,
rohan2794 and
w3aman
niladrih
force-pushed
the
nobidev/features/merge-cas-pvc
branch
from
0268e39
to
1acf440
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #190 +/- ##
===========================================
- Coverage 38.20% 37.93% -0.28%
===========================================
Files 36 36
Lines 3348 3372 +24
===========================================
Hits 1279 1279
- Misses 1987 2011 +24
Partials 82 82 ☔ View full report in Codecov by Sentry. |
|
Thanks guys, I missed it. Thanks for helping me out. |
niladrih
force-pushed
the
nobidev/features/merge-cas-pvc
branch
8 times, most recently
from
4598245
to
740e66d
Compare
No problem :) |
Signed-off-by: Nobi <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
In the typical use-case for the provisioner, an admin sets the config on the StorageClass, and a user sets the config on the PVC. The admin's config may set boundaries on to the volumes which the PVC config map try to override. Preferring StorageClass config when there is a conflict may be the right way to go. Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
niladrih
force-pushed
the
nobidev/features/merge-cas-pvc
branch
from
740e66d
to
f881a87
Compare
Signed-off-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #191
This change merges the CAS config on the PVC with the SC (SC get preference in case of conflict), when provisioning volumes. Imports changes from @nobiit's PR #144.