feat: Allow specifying additional labels to be applied to all helm chart resources #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sources This is added as a top-level `labels` map within the values file. If it is populated, these labels will be added to the storageclass. It is also added to the 'localpv.labels' variable, already included within every resource besides the storageclass. Signed-off-by: Andrew Lavery <[email protected]>
Signed-off-by: Andrew Lavery <[email protected]>
|
Is this something that you would consider? |
|
We shall take a look. Thanks for this. |
tiagolobocastro
requested review from
Abhinandan-Purkait,
niladrih and
abhilashshetty04
tiagolobocastro
approved these changes
May 8, 2024
niladrih
reviewed
May 8, 2024
|
Sounds good, thank you for the review/approval/promise of future merging! |
|
Thank you, and have a happy Fourth of July! |
Thank you, and wish you the same :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
There is currently no way to specify additional labels to be applied to the resources in the chart - only the pod itself, not even the deployment that creates those pods.
What this PR does?:
Adds a top-level
labelsmap within the values file. If it is populated, these labels will be added to the storageclass directly, and also to the 'localpv.labels' variable, which is already included within every resource besides the storageclass.Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
I rendered the yaml with
helm template ./deploy/helm/chartswith both an empty and populatedlabelsmap, and validated that labels were created in the approprate places.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.Where:
Most common types are:
*
feat- for new features, not a new feature for build script*
fix- for bug fixes or improvements, not a fix for build script*
chore- changes not related to production code*
docs- changes related to documentation*
style- formatting, missing semi colons, linting fix etc; no significant production code changes*
test- adding missing tests, refactoring tests; no production code change*
refactor- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes*
cherry-pick- if PR is merged in master branch and raised to release branch(like v0.4.x)IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.