feat: Add support to specify file permissions for pvc hostpaths

[sushiMix]

Pull Request template

Why is this PR required? What issue does it fix?:
Fixes #95.

What this PR does?:
It allows to configure default directory mode using LocaMode entry in cas.openebs.io/config.

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    cas.openebs.io/config: |
      - name: StorageType
        value: "hostpath"
      - name: BasePath
        value: "/opt/data/"
      - name: HostPathMode
        value: "770"
    openebs.io/cas-type: local
  name: local-path
provisioner: openebs.io/local
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: task-pv-claim
spec:
  storageClassName: local-path
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: task-pv-pod
spec:
  volumes:
    - name: task-pv-storage
      persistentVolumeClaim:
        claimName: task-pv-claim
  containers:
    - name: task-pv-container
      image: nginx
      ports:
        - containerPort: 80
          name: "http-server"
      volumeMounts:
        - mountPath: "/usr/share/nginx/html"
          name: task-pv-storage

check the file mode of the created folder (0770 instead of 0777)

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

• Fixes Add support to specify file permissions for pvc hostpaths  #95
• PR Title follows the convention of <type>(<scope>): <subject>
• Has the change log section been updated?
• [] Commit has unit tests
• [] Commit has integration tests
• (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
• (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

[sushiMix]

Sorry for last PR with a bad rebase when signing.

[niladrih]

Hi @sushiMix. There is already one file-mode/file-mode API in place over at the openebs/dynamic-nfs-provisioner repo.
PR link: openebs-archive/dynamic-nfs-provisioner#125

While I don't have any issues with this implementation, it'd be useful to have a stable cas-config API across openebs storage engines. Also, the above implemetation supports file-permissions as well, which may be useful to your use-case.

[sushiMix]

Hello @niladrih I did a test with storage class and then pvc annotation configuration.

After I did rebase and squashed the commits.

I only support the mode changed. The user and group are left to kubelet behavior (FsGroup is supported for local volume in kubernetes). Need a bit more code change to update the command sent.

[niladrih]

Great! Could you also add a documentation .md file in the docs directory with instructions on using this feature?

[codecov-commenter]

Codecov Report

Merging #157 (6e61d78) into develop (a4a9273) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
- Coverage    38.00%   37.61%   -0.40%     
===========================================
  Files           36       36              
  Lines         3365     3400      +35     
===========================================
  Hits          1279     1279              
- Misses        2004     2039      +35     
  Partials        82       82              

Files	Coverage Δ
...md/provisioner-localpv/app/provisioner_hostpath.go	0.00% <0.00%> (ø)
cmd/provisioner-localpv/app/config.go	13.69% <0.00%> (-3.61%)	⬇️

[sushiMix]

Great! Could you also add a documentation .md file in the docs directory with instructions on using this feature?

I updated the QuickStart, do you need a more detailed documentation?

@niladrih I added a specific page.

[niladrih]

Thank you for the changes @sushiMix! I have left some comments.

[niladrih]

Additionally, the enabled key is not required here. Mentioning the details in 'data' is good enough.

[sushiMix]

@niladrih Happy New Year, I had time to perform code modification.

[niladrih]

Hi @sushiMix. Could you add ginkgo tests to this PR to test your feature? You could use https://github.com/openebs-archive/dynamic-nfs-provisioner/blob/develop/tests/nfs_server_file_permissions_test.go as an example in this case.

Let me know if you need help with this.

Also, I am sorry I haven't been able to review this!