Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (ndm-operator) Allow claim sparse device #679

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat (ndm-operator) Allow claim sparse device #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/select/blockdevice/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ package blockdevice

import (
"fmt"

apis "github.com/openebs/node-disk-manager/api/v1alpha1"
"github.com/openebs/node-disk-manager/blockdevice"
)

// Filter selects a single block device from a list of block devices
Expand Down Expand Up @@ -58,10 +60,12 @@ func (c *Config) getCandidateDevices(bdList *apis.BlockDeviceList) (*apis.BlockD
FilterBlockDeviceName,
)
} else {
if c.ClaimSpec.DeviceType != blockdevice.SparseBlockDeviceType {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typecheck: undeclared name: blockdevice

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

// Unless explicitly specify DeviceType as sparse, device sparse will not be included
filterKeys = append(filterKeys, FilterOutSparseBlockDevices)
}

filterKeys = append(filterKeys,
// Sparse BDs can be claimed only by manual selection. Therefore, all
// sparse BDs will be filtered out in auto mode
FilterOutSparseBlockDevices,
FilterDeviceType,
FilterVolumeMode,
FilterNodeName,
Expand Down