Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(restore): set targetip on CVRs after restore is completed #1761

Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix(restore): set targetip on CVRs after restore is completed #1761

merged 1 commit into from
Nov 11, 2020

Conversation

zlymeda
Copy link
Contributor

@zlymeda zlymeda commented Nov 4, 2020

Auto-setting of targetip on CVR if openebs.io/restore-completed is found

Pull Request template

Why is this PR required? What issue does it fix?:
Currently, users have to set targetip on CVRs after restore. Corresponding change in openebs/velero-plugin#131 will mark CVRs which needs to update the targetip. Changes in this PR will check the annotation and set the targetip.

What this PR does?:
Sets targetip on CVRs marked with openebs.io/restore-completed annotation.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
make test in velero-plugin repository with changes deployed.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

related velero-plugin PR: openebs/velero-plugin#131
related cstor-operators PR: openebs-archive/cstor-operators#198

Checklist:

Copy link
Contributor

@mynktl mynktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zlymeda .
PR looks good. Given one comment about logging the error. PTAL.

Copy link

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

@mynktl mynktl added this to the 2.4.0 milestone Nov 10, 2020
Auto-setting of targetip on CVR if openebs.io/restore-completed is found

Signed-off-by: Ondrej Belusky <[email protected]>
@zlymeda
Copy link
Contributor Author

zlymeda commented Nov 10, 2020

I rebased with origin/master and squashed commits into single commit

@kmova kmova merged commit f4173eb into openebs-archive:master Nov 11, 2020
@zlymeda zlymeda deleted the fix/set-targetip branch November 11, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants