-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp3 storm surge #43
Wp3 storm surge #43
Conversation
So, with this PR you tend to merge in two datasets: TWL & storm surge and wave climate.
Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, nearly there I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more comments on the dataset formatting
Manually remove SLP pilot & GCTS 2000 collections & items (and catalog link for SLP pilot)
Dimcombs was outputting an empty dict in a list. This resulted in uwanted behaviour. Had to change the if statement. Not sure if correct, but its producing the right results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final changes in the PY files
Adding SS_WC & TWL datasets |
Merge with main before creating pull request, no issues show up now.