Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working on data reader for SPSS and Stata files #675

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Working on data reader for SPSS and Stata files #675

wants to merge 14 commits into from

Conversation

ecowan
Copy link
Contributor

@ecowan ecowan commented Jul 29, 2022

Closes #652

@ecowan ecowan marked this pull request as ready for review August 4, 2022 22:53
@ecowan ecowan requested a review from raprasad August 4, 2022 22:53
raprasad
raprasad reviewed Aug 5, 2022
View reviewed changes
server/Dockerfile Outdated Show resolved Hide resolved
raprasad
raprasad requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@raprasad raprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs better temp file handling and clean-up. e.g. sensitive data!
  • Check that integers in the original file aren't being converted to floats

server/opendp_apps/analysis/validate_release_util.py
if file_extension not in ['.csv', '.tab']:
spss_reader = SpssReader(filepath)
df = spss_reader.read()
df.to_csv('temp.csv')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is being written within the code structure, under "server/"
In addition, it's not being cleaned up afterward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raprasad raprasad raprasad requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SPSS and STATA files
3 participants
@ecowan @raprasad @ekraffmiller