Ordrv production fix #1093
Closed
Ordrv production fix #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to extract the relevant pod data in case there are multiple pods in a mono-repo like rollout fixes opendevstack#1011 fixes opendevstack#1011
This fixes an issue where the build bails out with: ```text • Task :codenarcMain FAILED FAILURE: Build failed with an exception. • V/hat went wrong: Execution failed for task ':codenarcMain'. • BUG! UNCAUGHT EXCEPTION: java.lang.invoke.MethodHandles$Lookup.<init>(java.lang.Class,int) ```
THIS IS AN UNRELATED CHANGE It fixes: ``` Number of parameters in constructor of class org.ods.orchestration.util.DocumentHistoryEntry exceeds maximum allowed (5). ```
We are now more graceful in what we accept as valid in this test.
This removes the nested closures. The `obj.every { ... }` was incorrect anyway.
This also allows us to test more easily,
as we are not mixing data retrieval and data munging in the same method any more
…in-mono-repository-setup # Conflicts: # src/org/ods/component/HelmDeploymentStrategy.groovy
(cherry picked from commit e4a6fe9)
…in-mono-repository-setup # Conflicts: # CHANGELOG.md # src/org/ods/component/HelmDeploymentStrategy.groovy # src/org/ods/openshift/OpenShiftResourceMetadata.groovy
…nts-file-repeats-image-in-mono-repository-setup # Conflicts: # CHANGELOG.md
That parameter was gone due to a previous change!
…in-mono-repository-setup # Conflicts: # CHANGELOG.md
…in-mono-repository-setup # Conflicts: # CHANGELOG.md
…charts-dependencies' into ordrv-production-fix # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
Please see the original comment, this is a collection of all the mentioned issues/PRs. This is so that the EDPiP tests run thru a state that actually exists in code at the time of merging and will test what ends up in master. Once this is merge, everything mentioned here will be marked as merged as well, those are -- after all -- the same commits, just collected together. |
michaelsauter
approved these changes
Apr 16, 2024
|
We are going to integrate them separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1066
fix #1038
fix #1011
relates #1074, #1044, #1023