Bug/989 bitbucketservice uses deprecated api call #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverhorror
force-pushed
the
bug/989-bitbucketservice-uses-deprecated-api-call
branch
from
31a135e
to
0d1fee3
Compare
Test HttpRequestService in HttpRequestServiceSpec
serverhorror
force-pushed
the
bug/989-bitbucketservice-uses-deprecated-api-call
branch
from
0d1fee3
to
17006d0
Compare
It is not necessary to Spy(BitbucketService ...) as we test this in BitbucketSerivceSpec already. Mocking the class is sufficient
@deprecated setBuildStatus(String buildUrl, String gitCommit, String state, String buildName) Non-Deprecated method setBuildStatus(String buildUrl, String repo, String gitCommit, String state, String buildName)
|
Usages left:
To deprecate the call we need the repo available ( @michaelsauter, @clemensutschig any good plan how to make this available ... umh ... everywhere? |
…pi-call # Conflicts: # CHANGELOG.md
|
There's still one call left. I can't really find a good way to get rid of it but we're mostly there now. |
Hi Martin, we are preparing a Quickstarter release at the moment. Once this is done I should have time to check this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #989