-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] some pkg versions for the Tensorflow ImageStream manifest #742
[Fix] some pkg versions for the Tensorflow ImageStream manifest #742
Conversation
this fixes versions of the CUDA bundle and Numpy packages
7eb58b0
to
67f84b8
Compare
/lgtm |
Good catch! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images Thanks for your reivew, guys! |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the changes.
please correct me if i m looking at wrong place. |
Hmm, did I check the wrong image content then? I'll try to check on Monday again, cause its weird then. |
@harshad16 , I checked the tensorflow image referenced in our params.env file currently. You can see that there are two Numpy versions shown by the quay.io actually:
Each was introduced in a different layer during the image build.
In the result image, we can truly see the following:
Truth is that I checked this with the downstream for 2.14RC1 build only via the test. Since the other images have the numpy updated to 2.1 already and the test showed this for this TensorFlow image also, I simply wen't on and updated this. But same data that I checked with the upstream image, can be seen also for the downstream 2.14 RC1 build TensorFlow image. So, I'll raise a new PR to revert this version and will check what the heck was with the test to understand this a bit. Thank you for noticing! |
This partially reverts the opendatahub-io#742 to fix the expected version in the final image.
So, I understand why the test failed now. I misinterpreted the test failure - it actually failed on the reason that the Numpy package version doesn't match to what we have in the other packages. So I amended test so it doesn't expect Numpy (and couple more because of the recently added check for the Trusty AI image) to have the version aligned - red-hat-data-services/ods-ci#1923. For the manifest partial revert of this PR, I raised #743 to make this consistent again. @harshad16 thank you, again, for noticing this! 🙂 |
this fixes versions of the CUDA bundle and Numpy packages
This is a followup for the #721. This comment exactly.
Description
How Has This Been Tested?
Merge criteria: