Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test versions for 3.11 #741

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

dibryant
Copy link
Contributor

Fixes for https://issues.redhat.com/browse/RHOAIENG-13612

Description

updated notebook test for python 3.11

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member

let's see how the ocp-ci jobs go, but after a quick look so far

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Oct 10, 2024

/lgtm

@atheo89
Copy link
Member

atheo89 commented Oct 10, 2024

/override ci/prow/rocm-notebooks-e2e-tests ci/prow/notebooks-ubi9-e2e-tests ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror ci/prow/images

Override the above tests since are not related to the changes but the related on inability to build mainly the rocm images

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests ci/prow/notebooks-ubi9-e2e-tests ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror ci/prow/images

Override the above tests since are not related to the changes but the related on inability to build mainly the rocm images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2b18f5c into opendatahub-io:main Oct 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants