Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeflare-sdk 0.21.1 version in 2024.1 for ray and certs support #740

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Oct 9, 2024

Description

Update codeflare-sdk 0.21.1 version in 2024.1 for certs support
JIRA: https://issues.redhat.com/browse/RHOAIENG-14201

How Has This Been Tested?

NA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jstourac
Copy link
Member

jstourac commented Oct 9, 2024

Are these left out intentionally?

$ grep -r codeflare-sdk | grep Pipfile: | grep -v python-3.8 | grep -v intel | grep -v 0.21.1
jupyter/rocm/pytorch/ubi9-python-3.9/Pipfile:codeflare-sdk = "~=0.19.1"
jupyter/rocm/tensorflow/ubi9-python-3.9/Pipfile:codeflare-sdk = "~=0.19.1"
runtimes/rocm-pytorch/ubi9-python-3.9/Pipfile:codeflare-sdk = "~=0.19.1"
runtimes/rocm-tensorflow/ubi9-python-3.9/Pipfile:codeflare-sdk = "~=0.19.1"

@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2024
@harshad16
Copy link
Member Author

Are these left out intentionally?

i had intentionally left them out, as we don't ship them, only built them for dev-preview
anyhow, included it for now, for having those built , in case we are required to upgrade the dev-preview details.

@atheo89
Copy link
Member

atheo89 commented Oct 10, 2024

/lgtm

@harshad16
Copy link
Member Author

/hold

@harshad16 harshad16 changed the title Update codeflare-sdk 0.21.1 version in 2024.1 for certs support Update codeflare-sdk 0.21.1 version in 2024.1 for ray and certs support Oct 11, 2024
@harshad16
Copy link
Member Author

Based on the approval, we got from the distributed-workload team . slack-link
Going to merge this for next sets of builds to be triggered.

thanks all for the review.

/approve

@harshad16
Copy link
Member Author

/unhold

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6728983 into opendatahub-io:2024a Oct 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants