-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeflare-sdk 0.21.1 version in 2024.1 for ray and certs support #740
Update codeflare-sdk 0.21.1 version in 2024.1 for ray and certs support #740
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Are these left out intentionally?
|
Signed-off-by: Harshad Reddy Nalla <[email protected]>
i had intentionally left them out, as we don't ship them, only built them for dev-preview |
/lgtm |
This is related to See discussion at the original PR and at |
/hold |
Based on the approval, we got from the distributed-workload team . slack-link thanks all for the review. /approve |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6728983
into
opendatahub-io:2024a
Description
Update codeflare-sdk 0.21.1 version in 2024.1 for certs support
JIRA: https://issues.redhat.com/browse/RHOAIENG-14201
How Has This Been Tested?
NA
Merge criteria: