-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the manifests in right order with minor fixes #735
Conversation
- Introduce ROCm based images to imagestream list - Updated ROCm based images with amd.com/gpu annotation Signed-off-by: Harshad Reddy Nalla <[email protected]>
71f38c7
to
b0a76a8
Compare
/lgtm |
Signed-off-by: Harshad Reddy Nalla <[email protected]>
/lgtm |
@harshad16: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you for the review |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daniellutz, harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Set the manifests in right order with minor fixes
Related-to: https://issues.redhat.com/browse/RHOAIENG-12628
Supersedes: #730
How Has This Been Tested?
Executed:
kustomize build manifests/base
Merge criteria: