Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the manifests in right order with minor fixes #735

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

harshad16
Copy link
Member

Description

Set the manifests in right order with minor fixes

  • Introduce ROCm based images to imagestream list
  • Updated ROCm based images with amd.com/gpu annotation

Related-to: https://issues.redhat.com/browse/RHOAIENG-12628
Supersedes: #730

How Has This Been Tested?

Executed: kustomize build manifests/base

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- Introduce ROCm based images to imagestream list
- Updated ROCm based images with amd.com/gpu annotation

Signed-off-by: Harshad Reddy Nalla <[email protected]>
@daniellutz
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2024
@daniellutz
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 48bcd45 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16
Copy link
Member Author

Thank you for the review
Merging this PR.
Please leave further comments, going to merge this.

@harshad16
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daniellutz, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 5, 2024
@harshad16 harshad16 merged commit da5d4bf into opendatahub-io:main Oct 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants