Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all images and Makefile calls to Python 3.8 #703

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

daniellutz
Copy link
Contributor

@daniellutz daniellutz commented Sep 19, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-12625

As 2024b branch is coming to development, all images based on Python 3.8 will be dropped, as Python 3.8 will only be supported on 2023b branch and for Habana based images that require support for them.

Description

All Python 3.8 based images need to be removed, as 2024b branch will not provide support anymore, only on branch 2023b.

This will involve the removal of the following images:

  • base/anaconda-python-3.8
  • base/ubi8-python-3.8
  • cuda/ubi8-python-3.8
  • habana/1.10.0/ubi8-python-3.8
  • habana/1.13.0/ubi8-python-3.8
  • jupyter/datascience/anaconda-python-3.8
  • jupyter/datascience/ubi8-python-3.8
  • jupyter/minimal/ubi8-python-3.8
  • runtimes/datascience/ubi8-python-3.8
  • runtimes/minimal/ubi8-python-3.8
  • runtimes/pytorch/ubi8-python-3.8
  • runtimes/tensorflow/ubi8-python-3.8

Also the image calls need to be removed from the Makefile, the CI matrix and any other places that reference to Python 3.8.

How Has This Been Tested?

  • Removal of all images based on and Makefile calls to Python 3.8

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • All Python 3.8 references and dependencies have been correctly removed

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@atheo89
Copy link
Member

atheo89 commented Sep 20, 2024

Thank you Daniel for this clean up!! 🙂
Could you remove also from this workbenches.md file the ubi8 references and the habana ones?

Otherwise /lgtm

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Makefile Outdated Show resolved Hide resolved
@jstourac
Copy link
Member

On top of what Adriana proposed, maybe we could also fix proper version in these:

cuda/ubi9-python-3.9/Dockerfile:      description="CUDA Python 3.9 builder image based on UBI8 for ODH notebooks" \
cuda/ubi9-python-3.9/Dockerfile:      io.k8s.description="CUDA Python 3.9 builder image based on UBI8 for ODH notebooks" \
cuda/ubi9-python-3.11/Dockerfile:      description="CUDA Python 3.11 builder image based on UBI8 for ODH notebooks" \
cuda/ubi9-python-3.11/Dockerfile:      io.k8s.description="CUDA Python 3.11 builder image based on UBI8 for ODH notebooks" \

But since there is a discussion whether we shouldn't remove the 3.9 from this branch also, so probably not worth of any effort.

Moreover, there are still some other references to UBI8, but it's probably not that important as it's usually used as an example value in our docs.

So, feel free to ignore this comment 😀

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jstourac
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@atheo89
Copy link
Member

atheo89 commented Sep 20, 2024

/override ci/prow/runtimes-ubi8-e2e-tests
/override ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-datascience-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebooks-ubi8-e2e-tests
/override ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebooks-ubi8-e2e-tests, ci/prow/runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-datascience-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror, ci/prow/runtimes-ubi8-e2e-tests

In response to this:

/override ci/prow/runtimes-ubi8-e2e-tests
/override ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-datascience-ubi8-python-3-8-pr-image-mirror
/override ci/prow/runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebooks-ubi8-e2e-tests
/override ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Sep 20, 2024

/override ci/prow/anaconda-ubi8-e2e-tests
/override ci/prow/habana-notebooks-e2e-tests
/override ci/prow/images
/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebook-base-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/anaconda-ubi8-e2e-tests, ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror, ci/prow/notebook-base-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror

In response to this:

/override ci/prow/anaconda-ubi8-e2e-tests
/override ci/prow/habana-notebooks-e2e-tests
/override ci/prow/images
/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebook-base-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
/override ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Sep 20, 2024

/override ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror

In response to this:

/override ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89 atheo89 changed the title [2024b] Remove all images and Makefile calls to Python 3.8 Remove all images and Makefile calls to Python 3.8 Sep 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6542483 into opendatahub-io:main Sep 20, 2024
29 checks passed
@jstourac
Copy link
Member

Could you remove also from this workbenches.md file the ubi8 references and the habana ones?

JFYI - I think that this one wasn't updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants