RHOAIENG-12535: Setup Jupyter 4 + Elyra environment on RHOAI/ODH

[paulovmr]

Description

• Prepare the notebooks images to use the next odh-elyra release.

• Remove commented code for Elyra patches that are being applied directly on ODH Elyra fork here.

• To do:

  • Confirm next version for odh-elyra release on PyPI
  • Update lock files

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[atheo89]

/lgtm

Just two comments to revert some comments back 🙂

[jiridanek]

The CI fails are legit, please fix CI before removing the wip label.

(Just noticed we have two different wip labels in this project defined ;)

[paulovmr]

/retest

[atheo89]

Hey Paulo, could you rebase this PR and update also pipfile for TrustyAI notebook?

[harshad16]

for rocm-tensorflow image, can you please include the
utils file https://github.com/opendatahub-io/notebooks/tree/main/jupyter/tensorflow/ubi9-python-3.11/utils and include the Dockerfile https://github.com/opendatahub-io/notebooks/blob/1600f89300c5c0ed709fbe5d807609de397a3b83/jupyter/tensorflow/ubi9-python-3.11/Dockerfile#L23C13-L23C84
so that those change can be fixed in rocm-tensorflow.

[paulovmr]

/retest

[paulovmr]

/retest

[harshad16]

/lgtm
/approve

Reason to approve:

• The changes bring in elyra back, so it can tested in proper manner
• The PR builds get override, if new changes are pushed, so lets get this one in.
• another note: as presubmit and postsubmit jobs get different cluster, some build would be faster in the main than in PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jstourac]

/lgtm /approve

Reason to approve:

• The changes bring in elyra back, so it can tested in proper manner
• The PR builds get override, if new changes are pushed, so lets get this one in.
• another note: as presubmit and postsubmit jobs get different cluster, some build would be faster in the main than in PR

I'm all for this. Just wondering whether we shouldn't use the latest dev1 Elyra release?

[paulovmr]

@jstourac Good point, since I'm rebasing it to fix conflicts, I'm also updating odh-elyra to use 4.0.0.dev1 version.

[paulovmr]

/retest

[paulovmr]

/retest

[atheo89]

/override ci/prow/images
Since it fails on ubi8 that we recently removed, the rest looks good
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/lgtm

[openshift-ci]

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/images
Since it fails on ubi8 that we recently removed, the rest looks good
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.