-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump codeflare-sdk
to version 0.19.1
for Python 3.11 images
#678
Conversation
/lgtm But maybe we should wait for the DW team to run their workflow instead? By that we'll also verify that it works for the newly introduced directories as expected: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1724088799543649 . |
@jstourac Could you please help me understand the reason we have to depend on something outside the repository out of our control? Now the workflow is broken because it is not prepared for 3.11 and we also have this issue. The workflow will also need changes when we move to Poetry. |
Basically we left this responsibility to do this package updates for the distributed workflows team, that is why the workflow is in their repo and is managed by them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@caponetto , as codeflare-sdk package belong to Distributed-workload team, and follows a anti-pattern of upgrade, i.e |
@caponetto: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Merging this in, to get the next PR in track. |
Description
Applying changes from #675 for Python 3.11 images to have
codeflare-sdk
in sync.How Has This Been Tested?
Merge criteria: