Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codeflare-sdk to version 0.19.1 for Python 3.11 images #678

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

caponetto
Copy link
Contributor

Description

Applying changes from #675 for Python 3.11 images to have codeflare-sdk in sync.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac
Copy link
Member

/lgtm

But maybe we should wait for the DW team to run their workflow instead? By that we'll also verify that it works for the newly introduced directories as expected: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1724088799543649 .

@caponetto
Copy link
Contributor Author

@jstourac Could you please help me understand the reason we have to depend on something outside the repository out of our control? Now the workflow is broken because it is not prepared for 3.11 and we also have this issue. The workflow will also need changes when we move to Poetry.

@jstourac
Copy link
Member

Basically we left this responsibility to do this package updates for the distributed workflows team, that is why the workflow is in their repo and is managed by them.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

Could you please help me understand the reason we have to depend on something outside the repository out of our control? Now the workflow is broken because it is not prepared for 3.11 and we also have this issue. The workflow will also need changes when we move to Poetry.

@caponetto , as codeflare-sdk package belong to Distributed-workload team, and follows a anti-pattern of upgrade, i.e
it get updated random order and doesn't follow our 6 month cadence for major update, this was an exception.
To adhere to the pact, that we have exception for this package. And the notebook not knowing when a release of codeflare-sdk happens, we rely only the workflow on DW.
we want to keep the responsibility balanced between the team.

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@caponetto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror 8c74794 link true /test runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror 8c74794 link true /test runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror
ci/prow/runtimes-ubi9-e2e-tests 8c74794 link true /test runtimes-ubi9-e2e-tests
ci/prow/images 8c74794 link true /test images
ci/prow/notebooks-ubi9-e2e-tests 8c74794 link true /test notebooks-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests 8c74794 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests 8c74794 link true /test rocm-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16
Copy link
Member

Merging this in, to get the next PR in track.
Thanks.

@harshad16 harshad16 merged commit abb56dd into opendatahub-io:main Sep 6, 2024
27 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants