-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-11300: Improve the library upgrade script for alternative sources #671
RHOAIENG-11300: Improve the library upgrade script for alternative sources #671
Conversation
Some examples in the comments for those regexps would make this a bit better to read, though 🙂 /lgtm |
4248917
to
f88d643
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
@paulovmr: Overrode contexts on behalf of paulovmr: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/rocm-notebooks-e2e-tests |
@paulovmr: Overrode contexts on behalf of paulovmr: ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Modify the library upgrade script to also work for libraries that have a alternative source defined in the Pipfile.
Currently, dependencies with the most used format are supported, for example:
tensorboard = "~=2.16.2"
. The dependencies that define both version and alternative source, for example:torch = {version = "~=2.4.0", index = "pytorch"}
should also be supported.How Has This Been Tested?
Manual executions, comparing the results with merged library upgrades PRs.
Merge criteria: