Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11300: Improve the library upgrade script for alternative sources #671

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

paulovmr
Copy link
Contributor

Description

Modify the library upgrade script to also work for libraries that have a alternative source defined in the Pipfile.

Currently, dependencies with the most used format are supported, for example: tensorboard = "~=2.16.2". The dependencies that define both version and alternative source, for example: torch = {version = "~=2.4.0", index = "pytorch"} should also be supported.

How Has This Been Tested?

Manual executions, comparing the results with merged library upgrades PRs.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac
Copy link
Member

Some examples in the comments for those regexps would make this a bit better to read, though 🙂

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2024
@caponetto caponetto self-assigned this Aug 15, 2024
@caponetto
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2024
@paulovmr
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulovmr
Copy link
Contributor Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@paulovmr: Overrode contexts on behalf of paulovmr: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@paulovmr
Copy link
Contributor Author

/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@paulovmr: Overrode contexts on behalf of paulovmr: ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f77a020 into opendatahub-io:main Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants