Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] RHOAIENG-9707 ci: dynamic testing of container images with pytest #629

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jul 22, 2024

image

This is a followup to

https://issues.redhat.com/browse/RHOAIENG-9707

Description

Example run

https://github.com/jiridanek/notebooks/actions/runs/10040438261/job/27746490803#step:9:19

Things to check or do

  • how this works with podman
  • how to test both kubernetes and docker with the same tests
  • how to run the notebook server and check that that works
  • generate test_* methods for every target in Makefile
  • commandline parameter to specify image to test
  • without parameter with image to test it can build the image as part of test

For now it uses images from

https://github.com/jiridanek/notebooks/actions/runs/10006075164/job/27658080202

and not from the current build.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek requested a review from jstourac July 22, 2024 12:09
Things to check or do

* [ ] how this works with podman
* [ ] how to test both kubernetes and docker with the same tests
* [ ] how to run the notebook server and check that that works
* [ ] generate test_* methods for every target in Makefile
* [ ] commandline parameter to specify image to test
* [ ] without parameter with image to test it can build the image as part of test

For now it uses images from

https://github.com/jiridanek/notebooks/actions/runs/10006075164/job/27658080202

and not from the current build.
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror a0163e2 link true /test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror a0163e2 link true /test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/runtimes-ubi8-e2e-tests a0163e2 link true /test runtimes-ubi8-e2e-tests
ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror 4b32eb2 link true /test runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/codeserver-notebook-e2e-tests 4b32eb2 link true /test codeserver-notebook-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests 4b32eb2 link true /test runtimes-ubi9-e2e-tests
ci/prow/intel-notebooks-e2e-tests 4b32eb2 link true /test intel-notebooks-e2e-tests
ci/prow/rstudio-notebook-e2e-tests 4b32eb2 link true /test rstudio-notebook-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests 4b32eb2 link true /test notebooks-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests 4b32eb2 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests 4b32eb2 link true /test rocm-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant