Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Telemetry level off #576

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 20, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-3348

Description

This PR set Telemetry off on code-server notebook.

How Has This Been Tested?

  1. Import the below image as custom notebook, with code-server-telemetry-off name on dashboard
    quay.io/opendatahub/workbench-images@sha256:3ea58b39357760cf7b35c0904ac15d303a2fabcebd6bf7c1211114dacef781bb
  2. Spin up the workbench that just imported (`code-server-telemetry-off``)
  3. Go to File -> Preferences -> settings ->search for telemetry -> check that the drop-down listbox is set to off the default value was all

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member Author

atheo89 commented Jun 20, 2024

Hey @jiridanek, can you reproduce the steps that you did at that time when you found that we had telemetry on, and check if we miss anything behind? So, far the only check that i did is to see if the elementary setting is off applied from .local/share/code-server/User/settings.json

@jiridanek
Copy link
Member

Hey @jiridanek, can you reproduce the steps that you did at that time when you found that we had telemetry on, and check if we miss anything behind? So, far the only check that i did is to see if the elementary setting is off applied from .local/share/code-server/User/settings.json

Checked, I wrote the steps at https://issues.redhat.com/browse/RHOAIENG-3348. Looks good.

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jiridanek
Copy link
Member

/retest-required

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 1a6ebcc link true /test notebooks-e2e-tests
ci/prow/intel-notebooks-e2e-tests 1a6ebcc link true /test intel-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

New changes are detected. LGTM label has been removed.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the excellent work
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 6bdc233 into opendatahub-io:main Jun 26, 2024
33 of 34 checks passed
@atheo89 atheo89 deleted the RHOAIENG-3348 branch October 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants