-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Telemetry level off #576
Conversation
Hey @jiridanek, can you reproduce the steps that you did at that time when you found that we had telemetry on, and check if we miss anything behind? So, far the only check that i did is to see if the elementary setting is |
Checked, I wrote the steps at https://issues.redhat.com/browse/RHOAIENG-3348. Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the excellent work
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-3348
Description
This PR set Telemetry off on code-server notebook.
How Has This Been Tested?
code-server-telemetry-off
name on dashboardquay.io/opendatahub/workbench-images@sha256:3ea58b39357760cf7b35c0904ac15d303a2fabcebd6bf7c1211114dacef781bb
telemetry
-> check that the drop-down listbox is set tooff
the default value wasall
Merge criteria: