Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update digest updater workflow #474

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 21, 2024

Related to:

Description

This PR updates the digest updater workflow to the following points:

  • Now, considers also the new notebooks such as code-server and rstudio-server
  • Updates runtimes (No more manual update!)
  • Update and clean up the overall code

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /prow/images

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override /prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89
Copy link
Member Author

atheo89 commented Mar 21, 2024

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this:

  • runtime upgrade should be a new workflow,
    as runtimes are updated , and injected
    and the next build of images is used.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes:

  • Please fix the spelling in the commit message.
  • The two commit are not clear cuts, if we want them separate
    we should have the runtime changes only in one commit
    or we should squash them both.

@atheo89
Copy link
Member Author

atheo89 commented Mar 28, 2024

Few changes:

  • Please fix the spelling in the commit message.
  • The two commit are not clear cuts, if we want them separate
    we should have the runtime changes only in one commit
    or we should squash them both.

It should be fixed now!

@atheo89 atheo89 requested a review from harshad16 March 28, 2024 14:29
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Mar 29, 2024
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6e2e5e5 into opendatahub-io:main Mar 29, 2024
3 checks passed
@atheo89 atheo89 deleted the RHOAIENG-2928 branch October 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants