Fix: Use code-server reference in all the files

[harshad16]

Fix: Use code-server reference in all the files

Description

Fix: Use code-server reference in all the files

Related-to: https://issues.redhat.com/browse/RHOAIENG-2188

How Has This Been Tested?

NA

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jstourac]

I can see that you updated also functional code. Then we have to check that we really didn't break anything with this one 😄

[jiridanek]

Code Server docs seem to either say "Code Server", capitalized, with space, or "code-server", lowercase and with hyphen (same as the cli command is named). I think we should not create our own hybrid.

I started doing the suggestions in GHA but this is best to address with find-and-replace locally, so I'll go delete them again.

[harshad16]

I can see that you updated also functional code. Then we have to check that we really didn't break anything with this one 😄

all good, tested this , it works without issue.
podman run -it -p 8888:8787 quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.9-pr-390

[rkpattnaik780]

Do we need to rename the extension files as well? Example

[rkpattnaik780]

/lgtm

Thanks for the changes!
Added one question.

[jiridanek]

/lgtm, with the small complaint about the wording of image description text

[openshift-ci]

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

/lgtm, with the small complaint about the wording of image description test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atheo89]

Do we need to rename the extension files as well? Example

I suggest maintaining the current file name as it was downloaded from the marketplace. We may lost traceability otherwise

[jiridanek]

Do we need to rename the extension files as well? Example

The names are named exactly as the files are named on https://open-vsx.org, I checked https://open-vsx.org/extension/ms-toolsai/vscode-jupyter-cell-tags. So I think we should not rename them.

[atheo89]

Thanks for changing all these references!
Apart of few suggestions, /lgtm

[atheo89]

/LGTM

[openshift-ci]

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror	2305f1e	link	true	/test notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[harshad16]

Thanks for all the reviews.
Merging this in.
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment