Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] of typo of the code-server package in the relevant manifest #388

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Fix] of typo of the code-server package in the relevant manifest #388

merged 1 commit into from
Jan 23, 2024

Conversation

jstourac
Copy link
Member

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this Jan 23, 2024
harshad16
harshad16 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Excellent catch 💯

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 07c31a1 into opendatahub-io:main Jan 23, 2024
4 checks passed
@jstourac jstourac deleted the codeServerTypo branch January 24, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@rkpattnaik780 rkpattnaik780 Awaiting requested review from rkpattnaik780

Assignees

@jstourac jstourac

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstourac @harshad16