Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vscode server imagestream and configurations to 2023b branch #382

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jan 10, 2024

Description

Move vscode server imagestream and configurations to 2023b branch

IMPORTANT NOTE Remaining item for the feature freeze sync, is to update the params.env file with the latest SHA digest produced by the 2023b ocp-ci configuration and the notebook-build-commit annotation with the short version of the build commit

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3d0f718 into opendatahub-io:2023b Jan 12, 2024
3 checks passed
jstourac pushed a commit to jstourac/notebooks that referenced this pull request Sep 30, 2024
feat(Rstudio): Upgrade RStudio to version 4.4.1 for 2024b
@atheo89 atheo89 deleted the vs-code-on-2023b branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants