-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Habana 1.13 notebook #380
Conversation
@harshad16 any idea what I'm doing wrong in the linting here? |
@Xaenalt I don't think you are doing anything wrong. |
@Xaenalt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Xaenalt for your pull request!
I added a comment for a small change that is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Images seems to be build
Testing of this is to be done async.
/lgtm
/approve
Merging to get this further done.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Habana currently added support for OpenShift 4.12.43 to their 1.13 driver series
Hopefully I did this update correctly
https://issues.redhat.com/browse/RHOAIENG-4343