Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on how you can install db client on code-server #379

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Dec 20, 2023

Add documentation on how you can install db client on code-server

Description

How Has This Been Tested?

Inspect the documentation on this link: https://github.com/atheo89/notebooks/blob/RHOAIENG-143/docs/Incorporate-database-cients-on-code-server.md

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thank for the great work.

one request would be if we can make the file name connected
incorporate-database-clients-on-code-server.md
this would make it easy for traversing through files,
with gaps, one need to use " quotes while using in cli

@atheo89
Copy link
Member Author

atheo89 commented Dec 20, 2023

Great point! Changed 🙂

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 0133259 into opendatahub-io:main Jan 2, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants