Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codeflare-sdk with the latest 0.12.0 #326

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Nov 9, 2023

Upgrade codeflare-sdk with the latest 0.12.0

Description

This fixes some of the codeflare-sdk issue.
Related-to: #327

How Has This Been Tested?

https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md
https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 0188ccd link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harshad16
Copy link
Member Author

Getting this merged as this fix is needed for the codeflare-sdk team.
Please keep an eye on this.

@harshad16 harshad16 merged commit 1d11963 into opendatahub-io:main Nov 10, 2023
35 of 37 checks passed
@atheo89
Copy link
Member

atheo89 commented Nov 10, 2023

Thanks Harshad, Here it is a follow up PR that updates the Image Streams to the latest version. #333

jstourac added a commit to jstourac/opendatahub-documentation that referenced this pull request Nov 16, 2023
jstourac added a commit to jstourac/opendatahub-documentation that referenced this pull request Nov 16, 2023
jstourac added a commit to jstourac/opendatahub-documentation that referenced this pull request Nov 16, 2023
jstourac added a commit to jstourac/opendatahub-documentation that referenced this pull request Nov 20, 2023
@chtyler
Copy link

chtyler commented Nov 20, 2023

This PR covers the documentation update for this change:
opendatahub-io/opendatahub-documentation#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants