Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] typo of the TensorFlow name in HabanaAI notebook manifest #325

Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Nov 9, 2023

Fixes the typo of TensorFlow name in the imagestream manifest for HabanaAI

This is just a fix of a typo to have it unified in the same name as TensorFlow workbench has it. This is not a functional change, just UI thing how this information is presented to the user.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Fixes the typo of TensorFlow name in the imagestream manifest for HabanaAI
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7958fc6 into opendatahub-io:main Nov 9, 2023
5 checks passed
@jstourac jstourac deleted the fixTypoTensorFlow branch November 10, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants