Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workaround patch for elyra validate #324

Merged

Conversation

rkpattnaik780
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 commented Nov 9, 2023

Patch to fix failing of elyra validation command for pipelines with default values.

Fixes #257

Description

elyra-validate cmd was failing for pipelines that contain both pipeline parameters and default properties.

How Has This Been Tested?

  1. Run the image in bash.
podman run -it --rm -p 8888:8888 quay.io/opendatahub/workbench-images:jupyter-datascience-ubi8-python-3.8-pr-324 bash
  1. Copy the files params.pipeline and params-test.py from here.
  2. Validate pipeline using elyra-validate command.
elyra-pipeline validate params.pipeline

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rkpattnaik780
Copy link
Contributor Author

/test notebook-codeserver-ubi9-python-3-9-pr-image-mirror

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the work 💯

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec30a7d into opendatahub-io:main Nov 15, 2023
15 checks passed
@harshad16 harshad16 mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] elyra-pipeline validate CLI command fails for pipelines with parameters and default properties
2 participants