Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023b][Fix] typo in some docker image labels k9s instead of k8s #312

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Nov 6, 2023

This is a cherry-pick of #308 into 2023b branch.

Relates to #310.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac requested review from harshad16 and atheo89 and removed request for rkpattnaik780 and dibryant November 6, 2023 20:12
@harshad16
Copy link
Member

/hold

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

thanks 💯

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4cb2736 into opendatahub-io:2023b Nov 28, 2023
3 checks passed
@jstourac jstourac deleted the k9sTypo2023b branch November 28, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants