Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vscode and r-studio to the base layer in ODH #300

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 31, 2023

Move vs code, r-studio, and cuda r-studio to the base layer to be included as defaults

Ref Issue: #283

Description

This PR vs code, r-studio, and cuda r-studio to the base layer and removes them from the additional

How Has This Been Tested?

  1. Deploy the operator by using the following config on the DataScienceCluster object
    workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: components/notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: ''
            sourcePath: base
            uri: 'https://github.com/opendatahub-io/notebooks/tarball/pull/300/head'
      managementState: Managed
  1. Ensure that the images are there
    image

  2. Spin up any of these three notebooks and check that they are working as expected.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
some suggestion

manifests/overlays/additional/README.md Outdated Show resolved Hide resolved
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 3, 2023
@openshift-ci openshift-ci bot merged commit 9737fab into opendatahub-io:main Nov 3, 2023
4 checks passed
@atheo89 atheo89 changed the title Move vscode and r-studio to the base layer Move vscode and r-studio to the base layer in ODH Nov 6, 2023
jstourac pushed a commit to jstourac/notebooks that referenced this pull request Jul 19, 2024
[rhoai-2.10] Backport fix for PyTorch notebook
@atheo89 atheo89 deleted the tracker-283 branch October 23, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants