Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tunings on the main in favor of the new release #279

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 23, 2023

Fine tunings on the main in favor of the new release

Related to: #273
Related also with a fix PR on ocp-ci: openshift/release#44716

Description

This PR includes the following changes:

  1. Changes the release from 2023a to 2023b
  2. Removes the remaining artifacts from TensorFlow and PyTorch UBI8
  3. Fix some URLs on the TrustyAI test_notebook.ipynb and do some fixes

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 changed the title Fine tunings on main in favor the new release Fine tunings on the main in favor of the new release Oct 23, 2023
@atheo89
Copy link
Member Author

atheo89 commented Oct 23, 2023

This PR fixes the e2e test. (We have exclude PyTorch and TensorFlow ubi8)
/override ci/prow/notebooks-e2e-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89
Copy link
Member Author

atheo89 commented Oct 23, 2023

This is a PR to fix the ci/prow/images test openshift/release#44716

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 💯

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Oct 23, 2023

/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 33399dd into opendatahub-io:main Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants