Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name for the notebook digest github action #268

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jstourac
Copy link
Member

Without a proper name the action isn't presented nicely in the GitHub UI so let's name it somehow. Feel free to propose better name, I just came up with something quickly 🙃

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 💯

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit a302c1a into opendatahub-io:main Oct 17, 2023
3 checks passed
@jstourac jstourac deleted the nameAction branch October 17, 2023 18:54
@atheo89 atheo89 mentioned this pull request Oct 20, 2023
@harshad16 harshad16 mentioned this pull request Nov 17, 2023
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/notebooks that referenced this pull request Jun 14, 2024
[release-2024a] sync the release-2024a branch with upstream 2024a branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants