Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Fix the conda based environment.yml #225

Closed
wants to merge 1 commit into from
Closed

[wip] Fix the conda based environment.yml #225

wants to merge 1 commit into from

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Sep 25, 2023 •
edited
Loading

Fix the conda based environment.yml

Description

Fix the conda based environment.yml

  • Sync elyra based changes on conda base notebook image

Related-to: #195

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Oct 2, 2023

Hey, @Xaenalt, on this PR Harshard incorporated the Elyra into anaconda notebook. Additionally, he included the prefix: /opt/app-root option in the environment.yml file to help address potential conflicts. However, it seems that the issue we were encountering still persists.
Could you please provide further details or insights on any additional upgrades or changes that we might need to consider in order to move forward effectively?

@atheo89 atheo89 requested a review from Xaenalt October 2, 2023 09:41
@jstourac jstourac mentioned this pull request Oct 16, 2023
Merged
jstourac added a commit to jstourac/release that referenced this pull request Oct 16, 2023
@jstourac
[opendatahub-io/notebooks] Disable CI checks for anaconda based images
cc4b9d0 
Let's disable Anaconda based image CI checks temporarily until the
opendatahub-io/notebooks#225 is resolved.
openshift-ci bot pushed a commit to openshift/release that referenced this pull request Oct 16, 2023
@jstourac
[opendatahub-io/notebooks] Disable CI checks for anaconda based images (
83d1b77 
#44385)

Let's disable Anaconda based image CI checks temporarily until the
opendatahub-io/notebooks#225 is resolved.
@harshad16 harshad16 changed the title Fix the conda based environment.yml [wip] Fix the conda based environment.yml Oct 17, 2023
jstourac added a commit to jstourac/release that referenced this pull request Oct 31, 2023
@jstourac
[red-hat-data-services/notebooks] Disable CI checks for anaconda base…
68c5514 
…d images

Let's disable Anaconda based image CI checks temporarily until the
opendatahub-io/notebooks#225 is resolved.
@jstourac jstourac mentioned this pull request Oct 31, 2023
Closed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 10, 2023 •
edited
Loading

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror 5215356 link true /test notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror 5215356 link true /test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror 5215356 link true /test notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror
ci/prow/habana-notebooks-e2e-tests 5215356 link true /test habana-notebooks-e2e-tests
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror 6d548e3 link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror
ci/prow/notebook-codeserver-ubi9-python-3-9-pr-image-mirror 6d548e3 link true /test notebook-codeserver-ubi9-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstourac jstourac mentioned this pull request Dec 7, 2023
Closed
@harshad16 harshad16 force-pushed the sync-conda branch 4 times, most recently from 2564741 to 64739d4 Compare December 11, 2023 20:42
@harshad16
Upgrade the conda image with new features
399e292 
- Sync elyra based changes on conda base notebook image

Signed-off-by: Harshad Reddy Nalla <[email protected]>
@harshad16
Copy link
Member Author

Closing the PR for now.
Will reopen a new one in future.

@harshad16 harshad16 closed this Mar 5, 2024
atheo89 pushed a commit to atheo89/notebooks that referenced this pull request Apr 15, 2024
@harshad16
Merge pull request opendatahub-io#225 from red-hat-data-services/dige…
90926d9 
…st-updater-8665769109

[Digest Updater Action] Update Notebook Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 Awaiting requested review from atheo89

@dibryant dibryant Awaiting requested review from dibryant

@Xaenalt Xaenalt Awaiting requested review from Xaenalt

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshad16 @atheo89