Skip to content

Commit

Permalink
[Fix/enhancement] dockerimage labels check and attempted to deduplicate
Browse files Browse the repository at this point in the history
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: #292
  • Loading branch information
jstourac committed Nov 6, 2023
1 parent 1162813 commit eee5072
Show file tree
Hide file tree
Showing 29 changed files with 255 additions and 115 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ REQUIRED_R_STUDIO_IMAGE_COMMANDS="curl python oc /usr/lib/rstudio-server/bin/rse
define build_image
$(eval IMAGE_NAME := $(IMAGE_REGISTRY):$(1)-$(IMAGE_TAG))
$(info # Building $(IMAGE_NAME) image...)
$(eval BUILD_ARGS := --build-arg BUILD_COMMIT_REF=$(RELEASE) --build-arg IMAGE_REGISTRY=$(IMAGE_REGISTRY))
$(if $(3),
$(eval BASE_IMAGE_NAME := $(IMAGE_REGISTRY):$(3)-$(IMAGE_TAG))
$(eval BUILD_ARGS := --build-arg BASE_IMAGE=$(BASE_IMAGE_NAME)),
$(eval BUILD_ARGS :=)
$(eval BUILD_ARGS := $(BUILD_ARGS) --build-arg BASE_IMAGE=$(BASE_IMAGE_NAME)),
)
$(CONTAINER_ENGINE) build --no-cache -t $(IMAGE_NAME) $(BUILD_ARGS) $(2)
$(CONTAINER_ENGINE) build --no-cache --tag $(IMAGE_NAME) $(BUILD_ARGS) $(2)
endef

# Push function for the notebok image:
Expand Down
13 changes: 9 additions & 4 deletions base/c9s-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
FROM quay.io/sclorg/python-39-c9s:c9s

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-base-centos-stream9-python-3.9" \
summary="Python 3.9 CentOS Stream 9 base image for ODH notebooks" \
description="Base Python 3.9 builder image based on CentOS Stream 9 for ODH notebooks" \
io.k8s.display-name="Python 3.9 c9s base image for ODH notebooks" \
io.k8s.description="Base Python 3.9 builder image based on C9S for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/base/c9s-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:base-c9s-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/base/c9s-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:base-c9s-python-3.9"

WORKDIR /opt/app-root/bin

Expand Down
13 changes: 9 additions & 4 deletions base/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
FROM registry.access.redhat.com/ubi8/python-38:latest

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-base-ubi8-python-3.8" \
summary="Python 3.8 base image for ODH notebooks" \
description="Base Python 3.8 builder image based on UBI8 for ODH notebooks" \
io.k8s.display-name="Python 3.8 base image for ODH notebooks" \
io.k8s.description="Base Python 3.8 builder image based on UBI8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/base/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:base-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/base/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:base-ubi8-python-3.8"

WORKDIR /opt/app-root/bin

Expand Down
13 changes: 9 additions & 4 deletions base/ubi9-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
FROM registry.access.redhat.com/ubi9/python-39:latest

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-base-ubi9-python-3.9" \
summary="Python 3.9 base image for ODH notebooks" \
description="Base Python 3.9 builder image based on UBI9 for ODH notebooks" \
io.k8s.display-name="Python 3.9 base image for ODH notebooks" \
io.k8s.description="Base Python 3.9 builder image based on UBI9 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/base/ubi9-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:base-ubi9-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/base/ubi9-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:base-ubi9-python-3.9"

WORKDIR /opt/app-root/bin

Expand Down
13 changes: 9 additions & 4 deletions codeserver/c9s-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

ARG CODESERVER_VERSION=v4.16.1

LABEL name="odh-notebook-code-server-c9s-python-3.9" \
summary="Code Server (VS Code) image with python 3.9 based on CentOS Stream 9" \
description="Code Server (VS Code) image with python 3.9 based on CentOS Stream 9" \
io.k8s.display-name="Code Server (VS Code) image with python 3.9 based on CentOS Stream 9" \
io.k8s.description="Code Server (VS Code) image with python 3.9 based on CentOS Stream 9" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/codeserver/c9s-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:codeserver-c9s-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/codeserver/c9s-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:codeserver-c9s-python-3.9"

USER 0

Expand Down
13 changes: 9 additions & 4 deletions cuda/c9s-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-cuda-c9s-python-3.9" \
summary="CUDA Python 3.9 base image for ODH notebooks" \
description="CUDA Python 3.9 builder image based on CentOS Stream 9 for ODH notebooks" \
io.k8s.display-name="CUDA Python 3.9 base image for ODH notebooks" \
io.k8s.description="CUDA Python 3.9 builder image based on C9S for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/cuda/c9s-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:cuda-c9s-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/cuda/c9s-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:cuda-c9s-python-3.9"

# Install CUDA base from:
# https://gitlab.com/nvidia/container-images/cuda/-/blob/master/dist/11.8.0/ubi8/base/Dockerfile
Expand Down
13 changes: 9 additions & 4 deletions cuda/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-cuda-ubi8-python-3.8" \
summary="CUDA Python 3.8 base image for ODH notebooks" \
description="CUDA Python 3.8 builder image based on UBI8 for ODH notebooks" \
io.k8s.display-name="CUDA Python 3.8 base image for ODH notebooks" \
io.k8s.description="CUDA Python 3.8 builder image based on UBI8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/cuda/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:cuda-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/cuda/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:cuda-ubi8-python-3.8"

# Install CUDA base from:
# https://gitlab.com/nvidia/container-images/cuda/-/blob/master/dist/11.4.2/ubi8/base/Dockerfile
Expand Down
13 changes: 9 additions & 4 deletions cuda/ubi9-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-cuda-ubi9-python-3.9" \
summary="CUDA Python 3.9 base image for ODH notebooks" \
description="CUDA Python 3.9 builder image based on UBI8 for ODH notebooks" \
io.k8s.display-name="CUDA Python 3.9 base image for ODH notebooks" \
io.k8s.description="CUDA Python 3.9 builder image based on UBI8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/cuda/ubi9-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:cuda-ubi9-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/cuda/ubi9-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:cuda-ubi9-python-3.9"

# Install CUDA base from:
# https://gitlab.com/nvidia/container-images/cuda/-/blob/master/dist/11.8.0/ubi8/base/Dockerfile
Expand Down
13 changes: 9 additions & 4 deletions habana/1.10.0/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

ARG ARTIFACTORY_URL="vault.habana.ai"
ARG VERSION="1.10.0"
ARG REVISION="494"
Expand Down Expand Up @@ -147,10 +152,10 @@ LABEL name="odh-notebook-habana-jupyter-1.10.0-ubi8-python-3.8" \
description="Jupyter HabanaAI 1.10.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
io.k8s.display-name="Jupyter HabanaAI 1.10.0 notebook image for ODH notebooks" \
io.k8s.description="Jupyter HabanaAI 1.10.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/habana/1.10.0/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:habana-jupyter-1.10.0-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/habana/1.10.0/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:habana-jupyter-1.10.0-ubi8-python-3.8"

# Replace Notebook's launcher, "(ipykernel)" with Python's version 3.x
RUN sed -i -e "s/Python.*/$(python --version| cut -d '.' -f-2)\",/" /opt/app-root/share/jupyter/kernels/python3/kernel.json && \
Expand Down
13 changes: 9 additions & 4 deletions habana/1.11.0/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

ARG ARTIFACTORY_URL="vault.habana.ai"
ARG VERSION="1.11.0"
ARG REVISION="587"
Expand Down Expand Up @@ -151,10 +156,10 @@ LABEL name="odh-notebook-habana-jupyter-1.11.0-ubi8-python-3.8" \
description="Jupyter HabanaAI 1.11.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
io.k8s.display-name="Jupyter HabanaAI 1.11.0 notebook image for ODH notebooks" \
io.k8s.description="Jupyter HabanaAI 1.11.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/habana/1.11.0/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:habana-jupyter-1.11.0-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/habana/1.11.0/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:habana-jupyter-1.11.0-ubi8-python-3.8"

# Replace Notebook's launcher, "(ipykernel)" with Python's version 3.x
RUN sed -i -e "s/Python.*/$(python --version| cut -d '.' -f-2)\",/" /opt/app-root/share/jupyter/kernels/python3/kernel.json && \
Expand Down
13 changes: 9 additions & 4 deletions habana/1.9.0/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

ARG ARTIFACTORY_URL="vault.habana.ai"
ARG VERSION="1.9.0"
ARG REVISION="580"
Expand Down Expand Up @@ -136,10 +141,10 @@ LABEL name="odh-notebook-habana-jupyter-1.9.0-ubi8-python-3.8" \
description="Jupyter HabanaAI 1.9.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
io.k8s.display-name="Jupyter HabanaAI 1.9.0 notebook image for ODH notebooks" \
io.k8s.description="Jupyter HabanaAI 1.9.0 notebook image with base Python 3.8 builder image based on ubi8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/habana/1.9.0/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:habana-jupyter-1.9.0-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/habana/1.9.0/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:habana-jupyter-1.9.0-ubi8-python-3.8"

# Replace Notebook's launcher, "(ipykernel)" with Python's version 3.x
RUN sed -i -e "s/Python.*/$(python --version| cut -d '.' -f-2)\",/" /opt/app-root/share/jupyter/kernels/python3/kernel.json && \
Expand Down
13 changes: 9 additions & 4 deletions jupyter/datascience/anaconda-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="jupyter-datascience-anaconda-python-3.8:latest" \
summary="Minimal Jupyter Notebook Source-to-Image for Python 3.8 applications. Uses Anaconda CE instead of pip." \
description="Notebook image based on Anaconda CE Python.These images can be used in OpenDatahub JupterHub." \
io.k8s.description="Notebook image based on Anaconda CE Python.These images can be used in OpenDatahub JupterHub." \
io.k8s.display-name="Anaconda s2i-minimal-notebook, python38" \
io.openshift.expose-services="8888:http" \
io.openshift.tags="python,python38,python-38,anaconda-python38" \
authoritative-source-url="https://quay.io//opendatahub/workbench-images:jupyter-datascience-anaconda-python-3.8" \
io.openshift.s2i.build.commit.ref="main" \
io.openshift.s2i.build.source-location="https://github.com/opendatahub-io/notebooks/jupyter/datascience/anaconda-python-3.8" \
io.openshift.s2i.build.image="quay.io/repository/opendatahub/workbench-images:jupyter-datascience-anaconda-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.s2i.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.s2i.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/jupyter/datascience/anaconda-python-3.8" \
io.openshift.s2i.build.image="${IMAGE_REGISTRY}:jupyter-datascience-anaconda-python-3.8"

ENV JUPYTER_ENABLE_LAB="1"
USER root
Expand Down
13 changes: 9 additions & 4 deletions jupyter/datascience/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-jupyter-datascience-ubi8-python-3.8" \
summary="Jupyter data science notebook image for ODH notebooks" \
description="Jupyter data science notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
io.k8s.display-name="Jupyter data science notebook image for ODH notebooks" \
io.k8s.description="Jupyter data science notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/jupyter/datascience/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:jupyter-datascience-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/jupyter/datascience/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:jupyter-datascience-ubi8-python-3.8"

WORKDIR /opt/app-root/bin

Expand Down
13 changes: 9 additions & 4 deletions jupyter/datascience/ubi9-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-jupyter-datascience-ubi9-python-3.9" \
summary="Jupyter data science notebook image for ODH notebooks" \
description="Jupyter data science notebook image with base Python 3.9 builder image based on UBI9 for ODH notebooks" \
io.k8s.display-name="Jupyter data science notebook image for ODH notebooks" \
io.k8s.description="Jupyter data science notebook image with base Python 3.9 builder image based on UBI9 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/jupyter/datascience/ubi9-python-3.9" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:jupyter-datascience-ubi9-python-3.9"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/jupyter/datascience/ubi9-python-3.9" \
io.openshift.build.image="${IMAGE_REGISTRY}:jupyter-datascience-ubi9-python-3.9"

WORKDIR /opt/app-root/bin

Expand Down
13 changes: 9 additions & 4 deletions jupyter/minimal/ubi8-python-3.8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

ARG BUILD_COMMIT_REF
ARG IMAGE_REGISTRY

ARG AUTHORITATIVE_SOURCE_URL="https://github.com/opendatahub-io/notebooks"

LABEL name="odh-notebook-jupyter-minimal-ubi8-python-3.8" \
summary="Minimal Jupyter notebook image for ODH notebooks" \
description="Minimal Jupyter notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
io.k8s.display-name="Minimal Jupyter notebook image for ODH notebooks" \
io.k8s.description="Minimal Jupyter notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
io.openshift.build.commit.ref="main" \
io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/jupyter/minimal/ubi8-python-3.8" \
io.openshift.build.image="quay.io/opendatahub/workbench-images:jupyter-minimal-ubi8-python-3.8"
authoritative-source-url="${AUTHORITATIVE_SOURCE_URL}" \
io.openshift.build.commit.ref="${BUILD_COMMIT_REF}" \
io.openshift.build.source-location="${AUTHORITATIVE_SOURCE_URL}/tree/main/jupyter/minimal/ubi8-python-3.8" \
io.openshift.build.image="${IMAGE_REGISTRY}:jupyter-minimal-ubi8-python-3.8"

WORKDIR /opt/app-root/bin

Expand Down
Loading

0 comments on commit eee5072

Please sign in to comment.