Fix: update the typo of ubi9 on trusty ai notebook and lint fixing

Signed-off-by: Harshad Reddy Nalla <[email protected]>
opendatahub-io · Jan 15, 2024 · 5db05d7 · 5db05d7
1 parent 0133259
commit 5db05d7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/notebooks-digest-updater-upstream.yaml b/.github/workflows/notebooks-digest-updater-upstream.yaml
@@ -97,7 +97,7 @@ jobs:
               echo $val
               sed -i "s|${val}=.*|${val}=${{ steps.hash-n.outputs.HASH_N }}|" manifests/base/commit.env
             done
-            git fetch origin  ${{ env.DIGEST_UPDATER_BRANCH }} && git pull origin  ${{ env.DIGEST_UPDATER_BRANCH }} && git add manifests/base/commit.env && git commit -m "Update image commits for release N via ${{ env.DIGEST_UPDATER_BRANCH }} GitHub action" && git push origin  ${{ env.DIGEST_UPDATER_BRANCH }}      
+            git fetch origin  ${{ env.DIGEST_UPDATER_BRANCH }} && git pull origin  ${{ env.DIGEST_UPDATER_BRANCH }} && git add manifests/base/commit.env && git commit -m "Update image commits for release N via ${{ env.DIGEST_UPDATER_BRANCH }} GitHub action" && git push origin  ${{ env.DIGEST_UPDATER_BRANCH }}
   update-n-1-version:
     needs: [initialize, update-n-version]
     runs-on: ubuntu-latest

diff --git a/jupyter/datascience/anaconda-python-3.8/environment.yml b/jupyter/datascience/anaconda-python-3.8/environment.yml
@@ -1,3 +1,4 @@
+---
 name: /opt/app-root
 channels:
   - conda-forge
@@ -413,4 +414,4 @@ dependencies:
   - zipp=3.17.0=pyhd8ed1ab_0
   - zlib=1.2.13=hd590300_5
   - zstd=1.5.5=hfc55251_0
-prefix: /opt/app-root
+prefix: /opt/app-root
diff --git a/jupyter/trustyai/ubi8-python-3.8/Dockerfile b/jupyter/trustyai/ubi8-python-3.8/Dockerfile
@@ -3,9 +3,9 @@ FROM ${BASE_IMAGE}
 
 LABEL name="odh-notebook-jupyter-trustyai-ubi8-python-3.8" \
     summary="Jupyter trustyai notebook image for ODH notebooks" \
-    description="Jupyter trustyai notebook image with base Python 3.8 builder image based on UBI9 for ODH notebooks" \
+    description="Jupyter trustyai notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
     io.k8s.display-name="Jupyter trustyai notebook image for ODH notebooks" \
-    io.k8s.description="Jupyter trustyai notebook image with base Python 3.8 builder image based on UBI9 for ODH notebooks" \
+    io.k8s.description="Jupyter trustyai notebook image with base Python 3.8 builder image based on UBI8 for ODH notebooks" \
     authoritative-source-url="https://github.com/opendatahub-io/notebooks" \
     io.openshift.build.commit.ref="main" \
     io.openshift.build.source-location="https://github.com/opendatahub-io/notebooks/tree/main/jupyter/trustyai/ubi8-python-3.8" \

diff --git a/manifests/base/jupyter-pytorch-notebook-imagestream.yaml b/manifests/base/jupyter-pytorch-notebook-imagestream.yaml
@@ -47,7 +47,7 @@ spec:
         opendatahub.io/notebook-python-dependencies: '[{"name":"PyTorch","version":"1.8"},{"name":"Tensorboard","version":"2.6"},{"name":"Boto3","version":"1.17"},{"name":"Kafka-Python","version":"2.0"},{"name":"Matplotlib","version":"3.4"},{"name":"Numpy","version":"1.19"},{"name":"Pandas","version":"1.2"},{"name":"Scikit-learn","version":"0.24"},{"name":"Scipy","version":"1.6"}]'
         openshift.io/imported-from: quay.io/opendatahub/notebooks
         opendatahub.io/image-tag-outdated: 'true'
-        opendatahub.io/notebook-build-commit:  $(odh-pytorch-gpu-notebook-image-commit-n-2)
+        opendatahub.io/notebook-build-commit: $(odh-pytorch-gpu-notebook-image-commit-n-2)
       from:
         kind: DockerImage
         name: $(odh-pytorch-gpu-notebook-image-n-2)