fix: address review comments

opendatahub-io · Jan 12, 2024 · 276922c · 276922c
1 parent 4efc18f
commit 276922c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/sec-scan.yml b/.github/workflows/sec-scan.yml
@@ -39,7 +39,7 @@ jobs:
          git checkout -b ${{ env.SEC_SCAN_BRANCH }}
          git push --set-upstream origin ${{ env.SEC_SCAN_BRANCH }}
 
-  update-n-version:
+  check-vulnerabilities:
     needs: [initialize]
     runs-on: ubuntu-latest
     permissions:
@@ -106,10 +106,10 @@ jobs:
       - name: execute py script  # run trial.py
         env:
           HASH_N: ${{ steps.hash-n.outputs.HASH_N }}
-          RELEASE_VERSION_N: 2023b
+          RELEASE_VERSION_N: ${{ env.RELEASE_VERSION_N }}
 
           HASH_N_1: ${{ steps.hash-n-1.outputs.HASH_N_1 }}
-          RELEASE_VERSION_N_1: 2023a
+          RELEASE_VERSION_N_1: ${{ env.RELEASE_VERSION_N_1 }}
 
           LATEST_MAIN_COMMIT: ${{ steps.hash-main.outputs.LATEST_MAIN_COMMIT }}
         run: make scan-image-vulnerabilities
@@ -120,7 +120,7 @@ jobs:
 
   # Creates the Pull Request
   open-pull-request:
-    needs: [update-n-version]
+    needs: [check-vulnerabilities]
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write

diff --git a/Makefile b/Makefile
@@ -473,4 +473,4 @@ refresh-pipfilelock-files:
 # For running manually, set the required environment variables
 .PHONY: scan-image-vulnerabilities
 scan-image-vulnerabilities:
-	python ci/security-scan/quay_security_analysis.py
+	python ci/security-scan/quay_security_analysis.py