Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify edge UWM info in the README #78

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Clarify edge UWM info in the README #78

merged 1 commit into from
Sep 27, 2023

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Sep 15, 2023

Description

Update the existing Observability setup instructions to add some minor context to the steps for enabling UserWorkloadMonitoring.

How Has This Been Tested?

Deployed manually to a new cluster

Merge criteria:

No errors introduced

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@adelton
Copy link
Contributor

adelton commented Sep 26, 2023

If amending / fixing the Makefile, please also document what it is for, where it is used. See also #110.

grdryn
grdryn approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adelton's comment about the Make targets not being mentioned in the instructions is a good point too though. Given that he has created #110 for that, I don't have strong feelings either way about whether that should be addressed here or in a follow-up PR for that issue.

piotrpdev
piotrpdev approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@piotrpdev piotrpdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge.

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 27, 2023

I'll follow up and merge this as part of the issue addressed in #110

@LaVLaS LaVLaS merged commit 9c71379 into opendatahub-io:main Sep 27, 2023
@LaVLaS LaVLaS deleted the doc-uwm-enablement branch September 27, 2023 05:00
@piotrpdev piotrpdev added kind/documentation Improvements or additions to documentation kind/enhancement New feature or request labels Oct 5, 2023
jackdelahunt pushed a commit to jackdelahunt/ai-edge that referenced this pull request Jan 23, 2024
@LaVLaS
Merge pull request opendatahub-io#78 from LaVLaS/doc-uwm-enablement
352b920 
Clarify edge UWM info in the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdryn grdryn grdryn approved these changes

@piotrpdev piotrpdev piotrpdev approved these changes

Assignees
No one assigned
Labels
kind/documentation Improvements or additions to documentation kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LaVLaS @adelton @grdryn @piotrpdev