Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for pull requests #133

Open
adelton opened this issue Oct 6, 2023 · 8 comments
Open

CI for pull requests #133

adelton opened this issue Oct 6, 2023 · 8 comments
Labels
help wanted Extra attention is needed kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible

Comments

@adelton
Copy link
Contributor

adelton commented Oct 6, 2023

As a contributor to this repo, I'd like to have an ability to run an automated CI workflow/pipeline on my my pull requests to make sure I do not break things.

Initiating the tests might be manual to avoid wasting resources.

@piotrpdev piotrpdev added help wanted Extra attention is needed kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible labels Oct 6, 2023
@piotrpdev
Copy link
Member

piotrpdev commented Oct 6, 2023

We talked about using Prow for this in one of the meetings, probably worth looking into. It might be better to wait until the PoC is in at least a somewhat stable state before doing this though.

@adelton
Copy link
Contributor Author

adelton commented Oct 6, 2023

Actually, especially for refactorings like #131 I would have liked to be able to use some automation to confirm that I don't break things.

For times when the PoC is more stable, #134 is more applicable.

@adelton
Copy link
Contributor Author

adelton commented Oct 6, 2023

As for the Prow link -- does it have some information there how to get hooked to https://prow.ci.openshift.org/? I only scanned those pages briefly but it seems like a documentation about setting up Prow but I'd much rather just hook to whatever existing instance is already out there. I wonder if https://github.com/openshift/test-infra is what we are looking for, specifically https://github.com/openshift/test-infra/blob/master/prow/jobs.md.

@adelton
Copy link
Contributor Author

adelton commented Oct 6, 2023

Actually, does Open Data Hub use Prow in any way?

@piotrpdev
Copy link
Member

@adelton
Copy link
Contributor Author

adelton commented Oct 6, 2023

Ah, so folks from our peer team(s) should be able to give us some hints how to onboard us.

@piotrpdev
Copy link
Member

Great, looks like @LaVLaS knows how 🥳 openshift/release#30719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible
Projects
None yet
Development

No branches or pull requests

2 participants