Build was broken, because Makefile still had chameleon references.

[apoz]

As per this commit:

commit 50ec793f00db2c21b022b531eaca6e13c0136fc3
Author: alshabib <[email protected]>
Date:   Tue Jan 31 15:28:32 2017 -0800

removing chameleon from voltha

Change-Id: Ied7a0eff178c6a23c01a1e10747f872c8976a5bb

I think there should be no references to chameleon in the Makefile.

In the repo there are still some tests for chameleon, may be those
should be deleted also.

With the current Makefile if you try to compile you get the following error:

(venv-linux) root@vOLTHA:/home/sysadmin/voltha# make
Makefile:85: warning: overriding recipe for target 'voltha'
Makefile:45: warning: ignoring old recipe for target 'voltha'
make -C voltha/protos
make[1]: Nothing to be done for 'default'.
make -C chameleon/protos
make[1]: *** chameleon/protos: No such file or directory.  Stop.
Makefile:112: recipe for target 'protos' failed
make: *** [protos] Error 2

Some other people is having the same problems:
https://groups.google.com/a/opencord.org/forum/#!msg/cord-dev/Q3XC0tfpefo/jBOP3x_5CgAJ

[opencord-gerrit]

Did you download only the voltha repo from git or did you use repo as described in the instructions? Cheers.

…

-- Ali

On Mar 3, 2017, 9:33 AM -0800, Andres Pozo Muñoz ***@***.***>, wrote: As per this commit: commit 50ec793 Author: alshabib ***@***.***> Date: Tue Jan 31 15:28:32 2017 -0800 (tel:32%202017%20-0800) removing chameleon from voltha Change-Id: Ied7a0eff178c6a23c01a1e10747f872c8976a5bb I think there should be no references to chameleon in the Makefile. In the repo there are still some tests for chameleon, may be those should be deleted also. With the current Makefile if you try to compile you get the following error: (venv-linux) ***@***.***:/home/sysadmin/voltha# make Makefile:85: warning: overriding recipe for target 'voltha' Makefile:45: warning: ignoring old recipe for target 'voltha' make -C voltha/protos make[1]: Nothing to be done for 'default'. make -C chameleon/protos make[1]: *** chameleon/protos: No such file or directory. Stop. Makefile:112: recipe for target 'protos' failed make: *** [protos] Error 2 Some other people is having the same problems: https://groups.google.com/a/opencord.org/forum/#!msg/cord-dev/Q3XC0tfpefo/jBOP3x_5CgAJ You can view, comment on, or merge this pull request online at: #1 Commit Summary Build was broken, because Makefile still had chameleon references. File Changes M Makefile (https://github.com/opencord/voltha/pull/1/files#diff-0) (13) Patch Links: https://github.com/opencord/voltha/pull/1.patch https://github.com/opencord/voltha/pull/1.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (#1), or mute the thread (https://github.com/notifications/unsubscribe-auth/ASxBmnpPz1eko6GPfOzZrWcuT_HzVpv7ks5riE7JgaJpZM4MSiPJ).

[apoz]

To make the PR, we just downloaded the code in git.
But we tested the build (with the original Makefile and this one) following the instruction steps with master branch in your repo. It would be great if you could verify that the build is failing with the instructions.

We tried to compile the voltha from scratch (in master branch) following the instructions and we were getting that error from make (which makes sense as the Makefile tries to compile the protos in chameleon folder, and that chameleon folder does not exist any longer in the repo in that branch).

Edit: Just in case it helps, we were following the Mac OS X instructions (adapting them to Ubuntu, because our server was using it).

KR,
Andrés

[alshabib]

It seems you have not followed the instructions in BUILD.md. You need to use repo to get voltha, sorry if that wasn't clear.

[apoz]

It was clear, Ali!

I think the difference was caused because we were following the other build path described in BUILD.md ("Building natively on MAC OS X") but using linux (a cloud image for Ubuntu 16.04) and not even following the steps exactly.

What we were doing:

1. Install the dependencies
   sudo apt-get install python python-pip python-virtualenv git docker
2. Then cloning the repo in github (not in bitbucket, is it the same code base in both sites?)
   git clone https://github.com/opencord/voltha.git
3. Installing some dependencies that were giving us trouble when tried to build automatically
   sudo apt-get install python-netifaces python-pcapy libpcap0.8-dev python-cryptography jq libssl-dev libffi-dev
4. Setting the env variable for the libssl version
   env CFLAGS="-I /usr/local/Cellar/openssl/1.0.2g_1/include"
5. Building the dependencies automatically
   source env.sh
6. Then running the make (and for some reason, with Make 4.1 it still tries to build something of chameleon)
   make

This is the error we were seeing:

make -C chameleon/protos
make[1]: *** chameleon/protos: No such file or directory.  Stop.
Makefile:112: recipe for target 'protos' failed
make: *** [protos] Error 2

We removed from the Makefile all chameleon references, and it compiled properly (and we were even able to boot the docker images). We will double check the BUILD.md file to follow the instructions properly.

Sorry for the inconvenience and thanks for your feedback!

Regards,
Andrés