[testing] #4327
Draft
[testing] #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the nil check to inside those functions, simplifying the callers. Signed-off-by: Kir Kolyshkin <[email protected]>
This code is not in libcontainer, IOW it is only used by a short lived binary (runc start/run/exec). Unlike libcontainer code, here we don't have to care about copying the structures supplied as input, meaning we can just reuse the pointers directly. Signed-off-by: Kir Kolyshkin <[email protected]>
For some reason, io priority is set in different places between runc start/run and runc exec (it is done much earlier for the latter). Let's unify the code flow of start/run and exec. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
As per - opencontainers/runtime-spec#1253 - opencontainers/runtime-spec#1261 Add some tests (alas it's impossible to test initial CPU affinity without adding debug logging). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
exec-cpu-aff
branch
from
5da8851
to
a1856a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.