-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal-device-properties-v2 initial commit #911
Terminal-device-properties-v2 initial commit #911
Conversation
This initial commit push the proposal consolidated from TIP OOPT community where it addresses the issues reported in Issue openconfig#910.
No major YANG version changes in commit 01cbc37 |
…BILITY_MODES_ORGANIZATIONSf
Changes to openconfig-terminal-device-properties.yang - Transceiver compatible modes inner list under the transceiver descriptor list items. - Missing description of "compatible-transceiver" list item. openconfig-terminal-device-property-type.yang - Include v.0.2.0 and revision statement.
Thanks @arthurMll . Two requests for you:
|
Dear @dplore
Orange plans to consume this model once it is made available northbound from devices. I hope this helps! regards Esther |
Dear @dplore,
From Telia Company side, there are plans to consume the proposed model in the future once it is available. |
Hi @dplore, all To answer this question:
Yes we confirm from Colt Technology Services that we are actively working on SDN architecture for packet-optical services and technologies where openconfig for open optical terminals will be one key building block. Thanks, Valéry Augais |
Thanks for all the comments on interest. I would like to see a review of the model by at least one operator. The review of the yang syntax is not critical, but the content is. The OC Operators who are regularly attending our calls and participating in reviews do not have a deep familiarity with this use case. @arthurMll if you find it helpful, may I suggest you organize a call with interested operators for a live review. We can utilize the weekly Operator call (at 09:00 PST on Tuesdays) or if needed, we could create a call just for this PR review. Also, @arthurMll perhaps you could create a tree view which in my experience helps reviewers more easily understand the model (reading only the yang it is difficult to understand the structure of the model). |
Dear @dplore , regarding your question:
Vodafone is interested in this model to be made available on optical terminal devices. Kind regards, Jeff Bouquier |
@arthurMll thanks for presenting this today. I more clearly understand the intent of this model now. Action items from the live review were:
|
Nokia is in agreement with the last model version. We didn’t discover any issues with it yet and we are planning to support it. CC: @arthurMll |
@arthurMll thanks for your updates. Can you rebase this to the latest comment on the master branch and resolve any conflicts? Then I will take a pass at review. |
…in a given transceiver Removing mode-descriptor-id key from Transceiver-compatible list to guarantee it is not possible the same mode-id is associated to two mode-descriptor-ids.
@dplore conflicts resolved and code ready for the final review |
/gcbrun |
/gcbrun |
Hi @dplore , In the last commit, I tried to resolve the following errors. Unfortunately, I cannot reproduce it locally so I am kind of blind until you do the next /gbcrun command. F0604 16:17:22.769055 888 generator.go:384] ERROR Generating GoStruct Code: key transceiver-descriptor-id had a leafref key (/openconfig-terminal-device-properties/linecard-descriptors/linecard-descriptor/compatible-transceivers/compatible-transceiver/transceiver-descriptor-id) in dir state that did not exist ([ oc-opt-term-properties:transceiver-descriptors oc-opt-term-properties:transceiver-descriptor oc-opt-term-properties:state oc-opt-term-properties:component-descriptor-id]) |
/gcbrun Sorry this is not automatic |
NEC optical transport team supports this proposal. We have a plan to release our software that implements the proposed properties. /CC @arthurMll |
/gcbrun |
/gcbrun |
Due to some issues compiling the mode. Those containers which contain a "state" subcontainer" needs to be out of the parent state container.
…ransceiver-compatible-modes" lists Keys of "compatible-transceiver" and "transceiver-compatible-modes" lists cannot reference an existing key leaf (a leaf which is being used as a key in another list) such as the case of the "mode-id" in "operational-mode-descriptors" list and the "component-descriptor-id" in "transceiver-descriptors" list. Thus, the leafrefs have been substituted by String or UINT16 leafs to accomodate an absolute reference attribute. Moreover, the keys have been modeled as leafref of the state leafs, following the tranditional openconfig style for lists modelling.
@dplore can you build it one more time? |
/gcbrun |
release/models/devices-manifest/openconfig-terminal-device-property-types.yang
Outdated
Show resolved
Hide resolved
release/models/devices-manifest/openconfig-terminal-device-properties.yang
Outdated
Show resolved
Hide resolved
@dplore can you make a final gcbrun and if everything ok the PR is ready to be merged in master |
Including in the descriptions of the transceivers-compatible-modes and linecard-descriptors/constrained-compatibles-modes, the need of referencing mode-ids which are present in the operational-mode-descriptors list.
Adding YANG MUST statements to the /transceiver-descriptors/.../transceiver-compatible-modes/mode-id and /linecard-descriptors/.../constrained-compatible-modes/mode-id leafs to enforce that values are present at : /operational-mode-descriptors/operational-modes
/gcbrun |
All checks are passed so from our side the PR is ready to be merged to public. @dplore please approve |
Final tree output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @arthurMll for all your work on this.
* Terminal-device-properties-v2 This initial commit push the proposal consolidated from TIP OOPT community where it addresses the issues reported in Issue openconfig#910.
* Terminal-device-properties-v2 This initial commit push the proposal consolidated from TIP OOPT community where it addresses the issues reported in Issue openconfig#910.
This initial commit push the proposal consolidated from TIP OOPT community where it addresses the issues reported in Issue #910.
Change Scope
This pull request covers a proposed solution to the issues described in #910.
The changes to the existing model are not backward compatible.
The summary of the changes proposed is the following:
1. Operational-mode list:
2. Mode-descriptors list:
3. Interoperable mode list.
4. Transceiver-descriptors list.
5. Linecard-descriptors list.
Following the model tree with the 5 blocks described above. In green the new leaves/containers are added in this proposal; in black the non-modified leaves, even if they have been reallocated within the tree under different containers/lists.
For more clarity on the above please check the following common definitions and assumptions defined during the design process of this proposal within the Telecom Infra Project (TIP) OOPT MUST project.
Common definitions
Assumptions