Skip to content

Merge pull request #95 from openconfig/fix-major-version-comment #165

Merge pull request #95 from openconfig/fix-major-version-comment

Merge pull request #95 from openconfig/fix-major-version-comment #165

Triggered via push November 30, 2023 19:15
Status Success
Total duration 1m 17s
Artifacts

go.yml

on: push
Matrix: go / Build and Test
Fit to window
Zoom out
Zoom in

Annotations

10 errors
go / Static Analysis: openconfig-ci/main.go#L15
should have a package comment
go / Static Analysis: post_results/misc-checks.go#L113
should replace filesReachedCount += 1 with filesReachedCount++
go / Static Analysis: post_results/misc-checks.go#L127
should replace ocVersionChangedCount += 1 with ocVersionChangedCount++
go / Static Analysis: post_results/misc-checks.go#L138
should replace ocVersionChangedCount += 1 with ocVersionChangedCount++
go / Static Analysis: openconfig-ci/ocdiff/ocdiff.go#L164
if block ends with a return statement, so drop this else and outdent its block
go / Static Analysis: cmd/check.go#L15
should have a package comment
go / Static Analysis: openconfig-ci/ocdiff/ocdiff.go#L155
exported method DiffReport.Sort should have comment or be unexported
go / Static Analysis: openconfig-ci/ocdiff/ocdiff.go#L15
package comment should be of the form "Package ocdiff ..."
go / Static Analysis: validators/misc-checks/ocversion/ocversion.go#L15
should have a package comment
go / Static Analysis: util/parseutil.go#L32
don't use ALL_CAPS in Go names; use CamelCase