Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n-iso-countries: Use raw JSONs #5113

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Conversation

Betree
Copy link
Member

@Betree Betree commented Sep 21, 2020

Going back to main repo (reverting #5041) and use raw JSON instead of helpers functions because there are still some code that break IE11.

I've proposed that the library should transpile its code in michaelwittig/node-i18n-iso-countries#193 (comment). In the meantime, we're sure that this implementation is 100% compatible with every browser.

Also added portuguese.

@Betree Betree requested a review from znarf September 21, 2020 08:31
@Betree Betree self-assigned this Sep 21, 2020
@render
Copy link

render bot commented Sep 21, 2020

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/60miidufa
✅ Preview: https://opencollective-frontend-git-deps-i18n-iso-countries-ie11.opencollective.vercel.app

@Betree Betree merged commit 666a337 into master Sep 22, 2020
@Betree Betree deleted the deps/i18n-iso-countries-ie11 branch September 22, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant